Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dropdown with navigation bar #474

Merged
3 commits merged into from
May 20, 2022
Merged

Replace dropdown with navigation bar #474

3 commits merged into from
May 20, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #461

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • The dropdown was replaced by a navigation bar, which makes the website more accessible when using the keyboard.

Screenshot of the fix

bild

Testing

  • Try keyboard navigation on the report page

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

Now the items in the nav bar should be navigatable using the keyboard.
@jonandernovella jonandernovella requested review from kusalananda, HenrikeW, a user and KattisLej May 20, 2022 09:25
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last! Works like a charm...

@ghost ghost merged commit cb6d671 into develop May 20, 2022
@ghost ghost deleted the dev/nav-btns branch May 20, 2022 10:25
@jonandernovella jonandernovella mentioned this pull request May 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keyboard shortcuts for save, help, etc
1 participant