Visual feedback on number of hours logged

[HenrikeW]

Related issue(s) and PR(s)

This PR closes #156

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other

List of changes made

• the sum cell for each day will have a check icon if 8 hours are logged on the day
• it will have a warning icon if less or more hours are logged
• the weekly sum cell will have the check icon if 40 hours were logged
• it will have a warning icon if less or more than 40 hours were logged
• the icons are only displayed for weeks in the past. (For the current week, it needs to be at least Saturday for the icons to be displayed).

Screenshot of the fix

Testing

• Go to a future week: you shouldn't see any icons
• Go to the current week: if it's before Saturday you shouldn't see any icons
• Go to a past week: you should see the icons as described above.
• Make a change in the hours of a time entry to meet the cases described above: As soon as you type, the icon should update together with the sum. (You don't need to save)

Further comments

Definition of Done checklist

• I have made an effort making the commit history understandable
• I have performed a self-review of my own code and commented any hard-to-understand areas
• Tests and lint/format validations are passing
• My changes generate no new warnings

[jonandernovella]

Looks good! i left a few comments

[KattisLej]

Starting review

[KattisLej]

In redmine you can log time on one day, more than 8 hours, but here the sum can be 40 but still showing warnings on the fields of the days. Will urdr not have this possibility?

[HenrikeW]

In redmine you can log time on one day, more than 8 hours, but here the sum can be 40 but still showing warnings on the fields of the days. Will urdr not have this possibility?

Good point. Will ask Johan about that.

[ghost]

Works ok, but do we know that all Urdr users really are expected to report 8 x 5 = 40 hours every week?

[kusalananda]

Works ok, but do we know that all Urdr users are expected to report 8 x 5 = 40 hours every week?

Users are expected to log precisely 40 hours every week, but there is no expectation that these should be distributed evenly over all days. Some users may prefer to log all their time for the week on Fridays.

Having said that, having the indicators on every day would not stop anyone from logging time only on Fridays.