Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the help page #472

Merged
merged 5 commits into from
May 20, 2022
Merged

updating the help page #472

merged 5 commits into from
May 20, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented May 20, 2022

Related issue(s) and PR(s)

This PR closes #469

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • the overview screenshot was updated
  • the descriptive text was updated
  • a section about known limitations was added
  • the html was made more semantic / unnecessary divs were removed

Screenshot of the fix

Testing

  • Read the new help page and make sure it's understandable and matches the current state of the service

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@KattisLej
Copy link
Contributor

Starting review

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pictures that need update are in place and the explanation texts are well formulated. I think it looks very good.

@jonandernovella jonandernovella self-requested a review May 20, 2022 08:09
Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to zoom in a lot to comfortably read the help page. I think it would be good to zoom in a bit more when making the screenshot.

@HenrikeW HenrikeW requested a review from jonandernovella May 20, 2022 09:36
@jonandernovella jonandernovella merged commit 0f331be into develop May 20, 2022
@jonandernovella jonandernovella deleted the dev/update-help-page branch May 20, 2022 10:12
@jonandernovella jonandernovella mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update help page according to current design
3 participants