Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return vacation if time entries don't exist #468

Merged
2 commits merged into from
May 20, 2022
Merged

Return vacation if time entries don't exist #468

2 commits merged into from
May 20, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #290

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

List of changes made

We now return a "Vacation row" if there is no time entries logged by the user.

Testing

  • Delete all time entries from your user
  • Log in and force reload

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella requested review from kusalananda, HenrikeW and a user May 19, 2022 15:16
ghost
ghost approved these changes May 20, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brutal, but still an improvement.

@ghost ghost merged commit f977bab into develop May 20, 2022
@ghost ghost deleted the dev/default-ent branch May 20, 2022 06:29
@jonandernovella jonandernovella mentioned this pull request May 20, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusalananda kusalananda Awaiting requested review from kusalananda

@HenrikeW HenrikeW Awaiting requested review from HenrikeW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handle empty recent issues
1 participant
@jonandernovella