Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tweaks #467

Merged
6 commits merged into from
May 20, 2022
Merged

Design tweaks #467

6 commits merged into from
May 20, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented May 19, 2022

NOTE: Before this PR is merged, the help page needs to be changed according to the changes in design.
If you approve, let me know so that I can update the help page before you merge.

Related issue(s) and PR(s)

This PR closes #443.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • the eye icon was replaced with an X
  • X and star icon were moved to the left of a row for aesthetic reasons
  • the distance between the two icons was increased to improve usability
  • the white margin below the header was decreased. In this process, unnecessary divs were removed

Screenshot of the fix

Testing

  • the page should work in the same way as before. Test if it does.

Further comments

  • The way GitHub marks changes it looks like a lot has changed in the JSX code in Report.tsx.
    In fact, only two divs were removed, the one starting in line 563 (className="usr-header") and the one starting in line 576 (className="main").
  • Issue Design tweaks #443 also contains one action point to make sure the footer is properly aligned. This will be fixed in PR #333: Replaced placeholder with label according to accessibility guid… #455 that also updates overall styling of the footer.

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested review from jonandernovella, KattisLej, a user and kusalananda May 19, 2022 14:33
@KattisLej
Copy link
Contributor

Starting code review

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the time logging and it works as before, the icons look good!

@ghost
Copy link

ghost commented May 20, 2022

Improvements, for sure! The only thing I think is weird is that if you, using keyboard navigation, press the favorite star to add a new favorite. the cursor jumps to the first line/row/issue of non-favorites instead of staying on the star/issue you made a favorite. This is not a blocker for merge, though.

@ghost ghost merged commit 66aee9c into develop May 20, 2022
@ghost ghost deleted the dev/design-tweaks branch May 20, 2022 06:29
@jonandernovella jonandernovella mentioned this pull request May 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design tweaks
2 participants