Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action for creating release images #466

Merged
merged 4 commits into from
May 19, 2022
Merged

Fix action for creating release images #466

merged 4 commits into from
May 19, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #465

Type of change

  • Bug fix (non-breaking change which fixes an issue)

List of changes made

  • The action is now using the head ref of the pr, and is triggered when a pr is closed and merged.

Testing

  • Making a new release

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

kusalananda
kusalananda approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's try that.

@kusalananda kusalananda merged commit 5b8387b into develop May 19, 2022
@kusalananda kusalananda deleted the dev/fix-act branch May 19, 2022 13:26
@jonandernovella jonandernovella mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusalananda kusalananda kusalananda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image releases are tagged wrongly
2 participants
@jonandernovella @kusalananda