Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help page #459

Merged
merged 11 commits into from
May 19, 2022
Merged

Add help page #459

merged 11 commits into from
May 19, 2022

Conversation

jonandernovella
Copy link
Contributor

@jonandernovella jonandernovella commented May 18, 2022 •
edited
Loading

Related issue(s) and PR(s)

This PR closes #445

Type of change

  • New feature (non-breaking change which adds functionality)

List of changes made

A help page for urdr users has been created under /help.

Testing

  • Navigate to /help

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella marked this pull request as ready for review May 18, 2022 15:32
ghost
ghost reviewed May 19, 2022
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but the menu and the help page cannot be reached using keyboard navigation. The menu should either be possible to reach or be replaced by buttons/links that can.

HenrikeW
HenrikeW reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@HenrikeW HenrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice explanations, and great with the screenshot and interactive elements. Some suggestions added in the text.

@jonandernovella
Copy link
Contributor Author

Looks great, but the menu and the help page cannot be reached using keyboard navigation. The menu should either be possible to reach or be replaced by buttons/links that can.

I opened issue #460 for this.

@jonandernovella jonandernovella requested review from a user and HenrikeW May 19, 2022 08:45
@HenrikeW HenrikeW merged commit 9a8ce04 into develop May 19, 2022
@HenrikeW HenrikeW deleted the dev/help-page branch May 19, 2022 08:54
@jonandernovella jonandernovella mentioned this pull request May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikeW HenrikeW HenrikeW approved these changes

@KattisLej KattisLej Awaiting requested review from KattisLej

@kusalananda kusalananda Awaiting requested review from kusalananda

@viklund viklund Awaiting requested review from viklund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add help page
2 participants
@jonandernovella @HenrikeW