Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ways to close the comment area #450

Merged
merged 2 commits into from
May 16, 2022
Merged

Add ways to close the comment area #450

merged 2 commits into from
May 16, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #424

Type of change

  • New feature (non-breaking change which adds functionality)

List of changes made

  • Close area on blur
  • Close area on ESC

Testing

  • Try to close a comment area pressing ESC or clicking away

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella
Update the handler of the show area
86f9124 
This will only enable the comment area now.
@jonandernovella
Add handlers for closing area button
0023c24 
Both using the ESC key or clicking away.
KattisLej
KattisLej approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks and works great!

@KattisLej
Copy link
Contributor

Have made a review and approved the PR

@HenrikeW HenrikeW merged commit 2ecaf72 into develop May 16, 2022
@HenrikeW HenrikeW deleted the dev/comments-esc branch May 16, 2022 14:25
@jonandernovella jonandernovella mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikeW HenrikeW HenrikeW approved these changes

@KattisLej KattisLej KattisLej approved these changes

@kusalananda kusalananda Awaiting requested review from kusalananda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve comments feature
3 participants
@jonandernovella @KattisLej @HenrikeW