Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/login design #449

Merged
merged 13 commits into from
May 16, 2022
Merged

Dev/login design #449

merged 13 commits into from
May 16, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented May 16, 2022

Related issue(s) and PR(s)

This PR closes #134 .

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Design

List of changes made

  • the login page got a new design
  • the information to use Redmine credentials was added together with a link to Redmine
  • a config file for ste CSS linter "stylelint" was added to allow legacy color notations. This was needed to make the box shadow work without the linter complaining.
  • the basic-button class was moved in the stylesheet so that other, more specific button classes that are defined later will override the styles from basic-button if two classes are used simultaneously.

Screenshot of the fix

Testing

  • open urdr without being logged in and see the new styling
  • try logging in with wrong credentials to see that the login error still works and looks nice.
  • log in and make sure nothing has changed on the /report page. Pay special attention to the buttons.

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested review from viklund, jonandernovella, kusalananda and a user May 16, 2022 11:03
@HenrikeW HenrikeW marked this pull request as draft May 16, 2022 11:05
Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I added some accessibility suggestions.

@HenrikeW HenrikeW marked this pull request as ready for review May 16, 2022 14:05
@HenrikeW HenrikeW requested a review from KattisLej May 16, 2022 14:05
@jonandernovella jonandernovella self-requested a review May 16, 2022 14:13
Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonandernovella jonandernovella merged commit 971528e into develop May 16, 2022
@jonandernovella jonandernovella deleted the dev/login-design branch May 16, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement design rules on login page
2 participants