bug fix introduced by the last commit in the footer #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay class, that caused the scroll to stop working. The class is only set when the spinner is shown
We centered the body and tried to fix the minimum size of the button.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a bug introduced by the last commit in the previous PR. The change height: 100vh in the loading-overlay class caused the scroll to stop working. Now the class is only set when the spinner is shown, to restore the page scroll
Related issue(s) and PR(s)
This PR closes #441
Type of change
Testing
Scroll and it works
Definition of Done checklist