Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper label + placeholder for quickadd input #333

Closed
HenrikeW opened this issue Apr 14, 2022 · 0 comments · Fixed by #455
Closed

proper label + placeholder for quickadd input #333

HenrikeW opened this issue Apr 14, 2022 · 0 comments · Fixed by #455
Assignees
@KattisLej
Labels
accessibility frontend This is likely affecting the frontend

Comments

@HenrikeW
Copy link
Contributor

Right now, the label just says "Issue" which is not very explanatory.
Should be at least as good as the placeholder text "Type issue number".

Also, rethink the placeholder text: Maybe be semantic and use a proper label, and then a placeholder that is an example, like "3499".
@HenrikeW HenrikeW added accessibility frontend This is likely affecting the frontend labels Apr 14, 2022
KattisLej added a commit that referenced this issue May 17, 2022
@KattisLej
#333: Replaced placeholder with label according to accessibility guid…
23a46ca 
…elines
@kusalananda kusalananda mentioned this issue May 17, 2022
Merged
8 tasks
KattisLej added a commit that referenced this issue May 18, 2022
@KattisLej
#333: Correcting aria label according to accessibility guidelines
8573b2c
KattisLej added a commit that referenced this issue May 18, 2022
@KattisLej
#333: Correcting from code review
b452987
KattisLej added a commit that referenced this issue May 18, 2022
@KattisLej
#333: Adding a label for activity according to review
0454957
KattisLej added a commit that referenced this issue May 19, 2022
@KattisLej
#333: Merged develop and fixed conflict
c078ed3
KattisLej added a commit that referenced this issue May 20, 2022
@KattisLej
#333: Merged develop and fixed conflicts in Report
032b02c
KattisLej added a commit that referenced this issue May 20, 2022
@KattisLej
#333: Adjustments in the whole footer in order to make elements visib…
55cb401 
…le even in zoomed state
KattisLej added a commit that referenced this issue May 20, 2022
@KattisLej
#333: Finaladjustment of unsaved changes text
4719282
KattisLej added a commit that referenced this issue May 20, 2022
@KattisLej
#333: Merged develop and fixed conflicts in index css
1b0cf56
KattisLej added a commit that referenced this issue May 20, 2022
@KattisLej
#333: Lint checks fixes
48f67d1
KattisLej added a commit that referenced this issue May 20, 2022
@KattisLej
#333: Lint checks fixes
b600a0f
KattisLej added a commit that referenced this issue May 20, 2022
@KattisLej
#333: Lint checks end of source newline
2103bf5
KattisLej added a commit that referenced this issue May 23, 2022
@KattisLej
#333: More space between heading and labels
49434ce
KattisLej added a commit that referenced this issue May 23, 2022
@KattisLej
#333: Spacing fixes and css classes, fixing bug of not seing total row
7978eed
KattisLej added a commit that referenced this issue May 23, 2022
@KattisLej
#333: Fix index conflict and merge develop
68a7257
KattisLej added a commit that referenced this issue May 23, 2022
@KattisLej
#333: Linter fix
eef9829
@ghost ghost closed this as completed in #455 May 24, 2022
ghost pushed a commit that referenced this issue May 24, 2022
Merge pull request #455 from NBISweden/fix/333-proper-label-placehold…
33b8708 
…er-for-quickadd-input

#333: Replaced placeholder with label according to accessibility guid…
@jonandernovella jonandernovella mentioned this issue May 24, 2022
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KattisLej KattisLej

Labels
accessibility frontend This is likely affecting the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#333: Replaced placeholder with label according to accessibility guid… NBISweden/urdr
2 participants
@HenrikeW @KattisLej