[AERIE-1906] Resolve `SerializedValue` LGTM errors by pcrosemurgy · Pull Request #238 · NASA-AMMOS/aerie

pcrosemurgy · 2022-07-07T17:47:32Z

Tickets addressed: AERIE-1906
Review: By commit
Merge strategy: Merge (no squash)

Description

From #220.

Resolves LGTM SerializedValue errors reported here.

Verification

All tests passing.

Documentation

None.

Future work

Resolve LGTM warnings (see https://lgtm.com/projects/g/NASA-AMMOS/aerie/alerts/?mode=tree).

merlin-sdk/src/main/java/gov/nasa/jpl/aerie/merlin/protocol/types/SerializedValue.java

merlin-sdk/src/test/java/gov/nasa/jpl/aerie/merlin/protocol/types/SerializedValueTest.java

Twisol · 2022-07-07T18:05:34Z

Sorry... GitHub notifications never actually tell me a PR is just a draft. 🤦‍♂️

pcrosemurgy · 2022-07-07T18:11:38Z

Sorry... GitHub notifications never actually tell me a PR is just a draft. 🤦‍♂️

No worries! All solid feedback :) Thanks

pcrosemurgy · 2022-07-07T19:39:28Z

Opened this PR prematurely. Am investigating the e2e-tests failure.

...-server/src/main/java/gov/nasa/jpl/aerie/scheduler/server/services/GraphQLMerlinService.java

skovati

LGTM! (heh) Smart move refactoring SerializedValue into an interface.

Should we create a separate ticket to capture the string escape work or were you planning on implementing that in this PR?

adrienmaillard

Looks good, thank you.

pcrosemurgy · 2022-07-18T00:21:07Z

Should we create a separate ticket to capture the string escape work or were you planning on implementing that in this PR?

Good point! I'll check in with Adrien on this, the preexisting TODO notes about string escaping should probably be removed in place of a ticket.

Make `SerializedValue` an interface, eliminating the need for explicit `equals()`, `toString()`, and `hashCode()` implementations.

- Capitalize endpoint method names from sveltejs/kit#5513 - Upgrade e2e Banananation from NASA-AMMOS/aerie#238

dyst5422 · 2022-07-19T00:08:47Z

Why are we doing sanitization for GQL instead of using variables? That's one of the great value propositions of the GraphQL standard - built in sanitization.

pcrosemurgy · 2022-07-19T00:09:48Z

Sure! I'll change the wording of the ticket.

dyst5422 · 2022-07-19T00:14:36Z

I don't think my comment is scoped to this ticket as the string formatting predates this ticket. Specifically looking at lines like

aerie/scheduler-server/src/main/java/gov/nasa/jpl/aerie/scheduler/server/services/GraphQLMerlinService.java

Lines 137 to 145 in 88d926a

    
           "query getPlanMetadata { " 
        
           + "plan_by_pk( id: %s ) { " 
        
           + "  id revision start_time duration " 
        
           + "  mission_model { " 
        
           + "    id name version " 
        
           + "    uploaded_file { name } " 
        
           + "  } " 
        
           + "  simulations(limit:1, order_by:{revision:desc} ) { arguments }" 
        
           + "} }"

where we were already doing string templating instead of using variables

pcrosemurgy · 2022-07-19T00:16:06Z

Yup! But your point 100% still stands, we should use variables. https://jira.jpl.nasa.gov/browse/AERIE-1949 should address this.

- Capitalize endpoint method names from sveltejs/kit#5513 - Upgrade e2e Banananation from NASA-AMMOS/aerie#238

Twisol reviewed Jul 7, 2022

View reviewed changes

merlin-sdk/src/main/java/gov/nasa/jpl/aerie/merlin/protocol/types/SerializedValue.java Show resolved Hide resolved

Twisol reviewed Jul 7, 2022

View reviewed changes

merlin-sdk/src/test/java/gov/nasa/jpl/aerie/merlin/protocol/types/SerializedValueTest.java Outdated Show resolved Hide resolved

Twisol reviewed Jul 7, 2022

View reviewed changes

merlin-sdk/src/test/java/gov/nasa/jpl/aerie/merlin/protocol/types/SerializedValueTest.java Outdated Show resolved Hide resolved

pcrosemurgy force-pushed the refactor/aerie-1906-lgtm-serialized-value branch 2 times, most recently from e06334d to c3a15a1 Compare July 7, 2022 19:14

pcrosemurgy mentioned this pull request Jul 7, 2022

[AERIE-1906] Resolve LGTM errors #220

Merged

pcrosemurgy force-pushed the refactor/aerie-1906-lgtm-serialized-value branch from c3a15a1 to 173be82 Compare July 7, 2022 19:31

pcrosemurgy marked this pull request as ready for review July 7, 2022 19:36

pcrosemurgy requested review from JoelCourtney, adrienmaillard, camargo, dyst5422, goetzrrGit, mattdailis and patkenneally as code owners July 7, 2022 19:36

pcrosemurgy force-pushed the refactor/aerie-1906-lgtm-serialized-value branch from 173be82 to 480b9de Compare July 8, 2022 18:29

pcrosemurgy commented Jul 12, 2022

View reviewed changes

...-server/src/main/java/gov/nasa/jpl/aerie/scheduler/server/services/GraphQLMerlinService.java Show resolved Hide resolved

skovati approved these changes Jul 13, 2022

View reviewed changes

adrienmaillard approved these changes Jul 14, 2022

View reviewed changes

pcrosemurgy added 4 commits July 17, 2022 17:21

SerializedValue: resolve LGTM "Inconsistent equals and hashCode"

3f9b9ce

Make `SerializedValue` an interface, eliminating the need for explicit `equals()`, `toString()`, and `hashCode()` implementations.

Use latest aerielander.jar

9ba281c

Enable JVM remote debugging for e2e tests

0aebd2a

Correctly serialize SerializedValue for GQL

88d926a

pcrosemurgy force-pushed the refactor/aerie-1906-lgtm-serialized-value branch from ce351ee to 88d926a Compare July 18, 2022 00:21

pcrosemurgy merged commit a034e1b into develop Jul 18, 2022

pcrosemurgy deleted the refactor/aerie-1906-lgtm-serialized-value branch July 18, 2022 02:21

camargo added a commit to NASA-AMMOS/aerie-ui that referenced this pull request Jul 18, 2022

build: upgrade deps to latest

f3ff4ee

- Capitalize endpoint method names from sveltejs/kit#5513 - Upgrade e2e Banananation from NASA-AMMOS/aerie#238

JosephVolosin pushed a commit to NASA-AMMOS/aerie-ui that referenced this pull request Aug 20, 2024

build: upgrade deps to latest

c5f4d97

- Capitalize endpoint method names from sveltejs/kit#5513 - Upgrade e2e Banananation from NASA-AMMOS/aerie#238

JosephVolosin pushed a commit to NASA-AMMOS/aerie-ui that referenced this pull request Oct 21, 2024

build: upgrade deps to latest

ea540b0

- Capitalize endpoint method names from sveltejs/kit#5513 - Upgrade e2e Banananation from NASA-AMMOS/aerie#238

dandelany pushed a commit to NASA-AMMOS/aerie-ui that referenced this pull request Aug 14, 2025

build: upgrade deps to latest

6b2ba0b

- Capitalize endpoint method names from sveltejs/kit#5513 - Upgrade e2e Banananation from NASA-AMMOS/aerie#238

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AERIE-1906] Resolve `SerializedValue` LGTM errors#238

[AERIE-1906] Resolve `SerializedValue` LGTM errors#238
pcrosemurgy merged 4 commits intodevelopfrom
refactor/aerie-1906-lgtm-serialized-value

pcrosemurgy commented Jul 7, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Twisol commented Jul 7, 2022

Uh oh!

pcrosemurgy commented Jul 7, 2022

Uh oh!

pcrosemurgy commented Jul 7, 2022

Uh oh!

Uh oh!

skovati left a comment

Uh oh!

adrienmaillard left a comment

Uh oh!

pcrosemurgy commented Jul 18, 2022

Uh oh!

dyst5422 commented Jul 19, 2022

Uh oh!

pcrosemurgy commented Jul 19, 2022

Uh oh!

dyst5422 commented Jul 19, 2022

Uh oh!

pcrosemurgy commented Jul 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

pcrosemurgy commented Jul 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Verification

Documentation

Future work

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Twisol commented Jul 7, 2022

Uh oh!

pcrosemurgy commented Jul 7, 2022

Uh oh!

pcrosemurgy commented Jul 7, 2022

Uh oh!

Uh oh!

skovati left a comment

Choose a reason for hiding this comment

Uh oh!

adrienmaillard left a comment

Choose a reason for hiding this comment

Uh oh!

pcrosemurgy commented Jul 18, 2022

Uh oh!

dyst5422 commented Jul 19, 2022

Uh oh!

pcrosemurgy commented Jul 19, 2022

Uh oh!

dyst5422 commented Jul 19, 2022

Uh oh!

pcrosemurgy commented Jul 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pcrosemurgy commented Jul 7, 2022 •

edited

Loading