[AERIE-1906] Resolve LGTM errors

[pcrosemurgy]

• Tickets addressed: AERIE-1906
• Review: By commit
• Merge strategy: Merge (no squash)

Description

Resolves LGTM errors reported here.

Verification

All tests passing.

Documentation

None.

Future work

Resolve LGTM warnings (see https://lgtm.com/projects/g/NASA-AMMOS/aerie/alerts/?mode=tree).

[Twisol]

By the way, the Javadoc for SerializedValue still refers to its ancient previous name, SerializedParameter. Could you update that in this PR by any chance? 🙏

[pcrosemurgy]

By the way, the Javadoc for SerializedValue still refers to its ancient previous name, SerializedParameter. Could you update that in this PR by any chance? 🙏

Done :)

[pcrosemurgy]

There's an interesting failure I'm looking into now:

Method 'gov.nasa.jpl.aerie.merlin.protocol.types.SerializedValue gov.nasa.jpl.aerie.merlin.protocol.types.SerializedValue.of(double)' must be InterfaceMethodref constant
java.lang.IncompatibleClassChangeError: Method 'gov.nasa.jpl.aerie.merlin.protocol.types.SerializedValue gov.nasa.jpl.aerie.merlin.protocol.types.SerializedValue.of(double)' must be InterfaceMethodref constant
	at gov.nasa.jpl.aerielander.mappers.seis.ChannelRateValueMapper.serializeValue(ChannelRateValueMapper.java:42)
	at gov.nasa.jpl.aerielander.mappers.seis.ChannelRateValueMapper.serializeValue(ChannelRateValueMapper.java:12)
	at gov.nasa.jpl.aerie.merlin.framework.Registrar$1.serialize(Registrar.java:57)
	at gov.nasa.jpl.aerie.merlin.driver.engine.SimulationEngine.serializeProfile(SimulationEngine.java:616)
	at gov.nasa.jpl.aerie.merlin.driver.engine.SimulationEngine.computeResults(SimulationEngine.java:455)
	at gov.nasa.jpl.aerie.scheduler.simulation.IncrementalSimulationDriver.getSimulationResultsUpTo(IncrementalSimulationDriver.java:152)
	at gov.nasa.jpl.aerie.scheduler.simulation.SimulationFacade.computeSimulationResultsUntil(SimulationFacade.java:249)
	at gov.nasa.jpl.aerie.scheduler.solver.PrioritySolver.getConflicts(PrioritySolver.java:503)
	at gov.nasa.jpl.aerie.scheduler.solver.PrioritySolver.satisfyGoalGeneral(PrioritySolver.java:425)
	at gov.nasa.jpl.aerie.scheduler.solver.PrioritySolver.satisfyGoal(PrioritySolver.java:286)
	at gov.nasa.jpl.aerie.scheduler.solver.PrioritySolver.solve(PrioritySolver.java:245)
	at gov.nasa.jpl.aerie.scheduler.solver.PrioritySolver.getNextSolution(PrioritySolver.java:112)
	at gov.nasa.jpl.aerie.scheduler.AerieLanderRulesTest.schedule(AerieLanderRulesTest.java:43)
	at gov.nasa.jpl.aerie.scheduler.AerieLanderRulesTest.firstRule(AerieLanderRulesTest.java:51)

Not familiar with must be InterfaceMethodref constant, will dig deeper.

Line 42 of ChannelRateValueMapper.java contains:

                    if (!map.containsKey("outRate")) {

Where map is of type Map<String, SerializedValue>.

[Twisol]

IncompatibleClassChangeError is like NoSuchMethodError in that it should only ever happen because you compiled code against one version of a class and then loaded it into a JVM with another. Make sure that your model JARs have been recompiled.

[pcrosemurgy]

Ahh that's right! This JAR is likely the one that's causing this snag: scheduler/src/test/resources/gov/nasa/jpl/aerie/scheduler/aerie-lander-0.11.1-SNAPSHOT.jar.

[pcrosemurgy]

Finally got the e2e tests figured out here :) Also note that #238 has been pulled out of this PR.

[mattdailis]

Nice work, Paul