This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
feat: Convert client.on_error into a proper event
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordOfPolls
suggested changes
Jul 29, 2022
naff/api/events/internal.py
Outdated
Comment on lines
171
to
175
| source: str | ||
| error: Exception | ||
| args: tuple[Any] = field(factory=tuple) | ||
| kwargs: dict[str, Any] = field(factory=dict) | ||
| ctx: Optional["Context"] = field(default=None) |
There was a problem hiding this comment.
Please can you docstring these attributes?
There was a problem hiding this comment.
I'm honestly not sure how to document args and kwargs.
LordOfPolls
added
Improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the error handler a dispatchable event, allowing Extensions listen to all events (prereq for #403)
Changes
Adds new Internal Event
naff.api.events.internal.ErrorChanges all calls to
client.on_errorto dispatch that event insteadAdds a non-breaking listener
client._on_eventthat calls the existing method.Also fixes implausible bug when
on_command_erroris called without a valid bot token.Checklist
Python 3.10.x