Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

[FEAT] Port Sentry integration from taipan to main library #403

Closed
silasary opened this issue Mar 17, 2022 · 4 comments
Closed

[FEAT] Port Sentry integration from taipan to main library #403

silasary opened this issue Mar 17, 2022 · 4 comments
Labels
Improvement Something that is already implemented but can be done better

Comments

@silasary
Copy link
Collaborator

This is relatively easy, I'm just waiting for Voice to get merged before I do it.

@silasary silasary added the Improvement Something that is already implemented but can be done better label Mar 17, 2022
@Wolfhound905
Copy link
Collaborator

@silasary hey is there any update on this?

@artem30801
Copy link
Contributor

In my opinion, all external integrations should not be in this repo (even in ext), but instead be placed in separate repos under the same org, to be optional dependencies

@silasary
Copy link
Collaborator Author

silasary commented Aug 3, 2022

I've been thinking about that, and I'm very torn. Having stuff in external repos reduces discoverability, and makes the features a lot less likely to be used.

naff_audio must be separate for messy reasons, but for most extensions, I'd rather them be relatively painless and selling points for the library, rather than hidden, generally unknown 2nd-party plugins.

Where possible, I'd much rather have them shipped in ext, and have any additional dependencies locked behind an extra, rather than "This really cool feature exists, but you'd never know it unless you happened to be looking at Discord the one day a year someone brings it up"

@compil3
Copy link
Contributor

compil3 commented Aug 14, 2022

I would definitely use if it were shipped with the library, I already do but having less things to manually configure that are quality of life improvements, in my eyes are well worth it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Improvement Something that is already implemented but can be done better
Projects
None yet
Development

No branches or pull requests

5 participants