This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
NAFF V1 #488
Merged
NAFF V1 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consts are... constant, use a tuple
* tests: Merge snek-tests into lib pytests * test: install voice deps to env * tests: skip voice on non-voice extra * fix: Wait for member update event * tests: Use pyproj for coverage * tests: Remove now redundant pragmas * tests: prevent multiple test-bots running concurrently
This better be the last time i rename these objects
Kigstn
approved these changes
May 17, 2022
zevaryx
approved these changes
May 17, 2022
|
Re-requesting reviews due to changes |
Kigstn
approved these changes
May 19, 2022
* feat: Add typing context manager At the request of Astrea * feat: Add channel.typing alias
* feat: Add asset.as_url * feat: allow users to pass extension without dot
* fix: Generate fallback channel object when Forbidden * fix: prevent caching errors with pre-cached recipients * fix: generate dummy DM channel on demand
* fix: Ensure subprocess is killed on linux * fix: handle small audio files better
zevaryx
approved these changes
May 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
Goodbye snek, hello NAFF. This PR concludes our rebrand from
Dis-SnektoNAFF, and as an extra treat; Improves parts of the library/repo.Note to org-member reviewers:
By approving this PR you are indicating you have no breaking changes planned short term. Obviously we don't want to release
NAFF 2.0.0a day after1.0.0Changes
Snakeclient ->ClientScaletoCogmodels/snek->models/naffSnakeException->NaffExceptionSnakeBotUser->NaffUSergrow_scale->mount_cogshed_scale->drop_cogget_scales->Client.get_cogsget_scale->Client.get_cogsSnake.sync_scales->Client.sync_cogsSnake.scales->ClientcogsCommand.scale->Command.cogScale.*scale*->Cog.*cog*raw_socket_event->raw_gateway_eventProbably a load more renames
Application.cover_imageis now anAssetApplicationattrs for App DiscoveryFormDataprocessing intohttp_client.requestChecklist
Python 3.10.x