Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat: Make Extension.name public #494

Merged
merged 1 commit into from
May 20, 2022
Merged

feat: Make Extension.name public #494

merged 1 commit into from
May 20, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Breaking if someone was daft enoug to be using a private attribute when public aliases exist.

This PR makes Extension.__name public under Extension.name at the request of @Astrea49
image

As far as i can tell this breaks nothing

Changes

  • Remove Extension.name property
  • Rename Extension.__name -> Extension.name

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@AstreaTSS
Copy link
Contributor

/ok-to-test

@LordOfPolls LordOfPolls merged commit 1661e22 into dev May 20, 2022
@LordOfPolls LordOfPolls deleted the protec branch May 20, 2022 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AstreaTSS AstreaTSS AstreaTSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @AstreaTSS