improve the copy script to automatically find the right container names#7567
Merged
TheoChevalier merged 2 commits intomainfrom Oct 12, 2021
Merged
improve the copy script to automatically find the right container names#7567TheoChevalier merged 2 commits intomainfrom
TheoChevalier merged 2 commits intomainfrom
Conversation
|
This PR introduces visual differences. Click here to inspect the diffs. |
danielfmiranda
approved these changes
Oct 5, 2021
Collaborator
danielfmiranda
left a comment
danielfmiranda
left a comment
There was a problem hiding this comment.
Works great for me @Pomax!
TheoChevalier
approved these changes
Oct 6, 2021
Contributor
TheoChevalier
left a comment
TheoChevalier
left a comment
There was a problem hiding this comment.
Confirming it works out of the box here, many thanks 🙏
TheoChevalier
temporarily deployed
to
foundation-s-update-cop-addq8m
|
This PR introduces visual differences. Click here to inspect the diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No associated issue, follow-up to #7522, this makes the copy script look for the container names based on
docker ps, so it no longer has any hardcoded container names. It also now force-drops the db, so that even if the database is in use (even if it's not, but there's some .lock file somewhere in the postgres docker image) things keep working.