[BE/FE] Mozfest - Spaces Cards by stevedya · Pull Request #7439 · MozillaFoundation/foundation.mozilla.org

stevedya · 2021-09-21T17:06:39Z

Related PRs/issues #7426

Checklist

Changes in Models:

Did I squash my migration?

*Screenshot

github-actions · 2021-09-27T19:28:01Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-09-27T20:24:55Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-09-28T05:50:15Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-09-28T06:21:56Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-09-28T06:25:07Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-09-29T20:10:12Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-09-30T03:10:49Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-09-30T03:16:15Z

This PR introduces visual differences. Click here to inspect the diffs.

sabrinang · 2021-10-04T16:45:24Z

Hi @stevedya, can you update the sample test page link so I can help review? Currently the deployment to https://foundation-s-feature-be-gnh4mi.herokuapp.com/ is inactive for me

b-ggs · 2021-10-05T14:32:20Z

Hey @sabrinang! I don't think we have access to provision deployments to Heroku. Is there a bot that we can use to deploy a testing environment?

sabrinang · 2021-10-05T18:18:13Z

@stevedya Can you link to the specific sample page with the space cards on the deployment https://foundation-s-feature-be-bmgzdd.herokuapp.com/en/ for me to review?

kristinashu · 2021-10-05T21:50:24Z

@sabrinang I set up a test page here https://mozfest-foundation-s-feature-be-bmgzdd.mofostaging.net/en/spaces/ but it would be good if you also log into the CMS as test it out further there.

stevedya · 2021-10-06T01:25:56Z

@kristinashu Awesome, Thank you Kristina! 😊

sabrinang

Type

space card heading: follow .h5-heading style line-height (29px)
space card body copy: follow .body style (18px/27px) size and line-height
reference https://foundation.mozilla.org/en/style-guide/#typography

CMS

if you can only have one link field anyway, can you remove the disabled + signs above and below to clean up the UI and save some vertical space?

Image Alignment

for various desktop/tablet breakpoints, when the text is short the image alignment should still align right to keep the layout organized

Related issue: #7428

* Spaces cards start * Spaces grid spacing * Update spaces_cards heading' * Add in backend django jijna vars * Revert mozfest-base * Revert package-lock file to normal * Convert section heading to h2 for a11y

github-actions · 2021-10-06T19:44:34Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-10-06T20:36:26Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-10-07T20:13:30Z

This PR introduces visual differences. Click here to inspect the diffs.

stevedya · 2021-10-07T20:39:01Z

Hey @sabrinang, we have made changes to this as per your feedback. It shows the deployment url as this:
Test Url. Hopefully this works for you if not maybe @kristinashu can assist?

Pomax

This looks pretty good to me.

sabrinang

The type size and image alignment looks good, thanks for making those updates! 👍

stevedya self-assigned this Sep 21, 2021

mofodevops temporarily deployed to foundation-s-feature-be-gnh4mi September 21, 2021 17:07 Inactive

stevedya mentioned this pull request Sep 27, 2021

FE: Mozfest Spaces Cards #7427

Closed

22 tasks

b-ggs marked this pull request as ready for review September 28, 2021 06:03

b-ggs self-assigned this Sep 28, 2021

b-ggs unassigned b-ggs and stevedya Sep 30, 2021

b-ggs requested review from Pomax and sabrinang September 30, 2021 02:58

b-ggs assigned Pomax and sabrinang Sep 30, 2021

danielfmiranda temporarily deployed to foundation-s-feature-be-bmgzdd October 5, 2021 17:11 Inactive

sabrinang requested changes Oct 6, 2021

View reviewed changes

mofodevops temporarily deployed to foundation-s-feature-be-bmgzdd October 6, 2021 19:13 Inactive

boggs added 3 commits October 7, 2021 03:28

Add common reusable link blocks

fb708a0

BE: Mozfest Spaces Cards

c27362d

Related issue: #7428

Add link property

ce5cd43

boggs and others added 12 commits October 7, 2021 03:28

Organize imports

2b5c469

Add title to SpaceCardListBlock

754b8fd

Use StreamBlock for page field

43b4b1e

Remove unused imports

8e6bae7

[7427] Spaces cards FE (#7444)

94e5275

* Spaces cards start * Spaces grid spacing * Update spaces_cards heading' * Add in backend django jijna vars * Revert mozfest-base * Revert package-lock file to normal * Convert section heading to h2 for a11y

Rename template to work with BE, adjust variables to work with BE

37b4f08

Update migrations

f438cc2

Rename template

1ee0782

Update card href

0497842

Update type styles, grid and flexbox width

62093f7

Only add Spaces Cards to Mozfest-related pages

f8651d0

Update migrations

74c33b7

boggs added 2 commits October 7, 2021 03:53

Use common link components

5971cf4

Fix template href

5bb5e13

b-ggs force-pushed the feature/BE-FE-spaces-cards branch from a37d810 to 5bb5e13 Compare October 6, 2021 20:02

mofodevops temporarily deployed to foundation-s-feature-be-bmgzdd October 6, 2021 20:02 Inactive

Fix grid col count with singup block

fa58ac0

mofodevops temporarily deployed to foundation-s-feature-be-bmgzdd October 7, 2021 19:42 Inactive

stevedya requested a review from sabrinang October 7, 2021 20:40

Pomax approved these changes Oct 7, 2021

View reviewed changes

Pomax mentioned this pull request Oct 7, 2021

[BE/FE] Mozfest Current Events Slider #7457

Merged

1 task

sabrinang mentioned this pull request Oct 7, 2021

[MozFest] Design support and review #7490

Closed

sabrinang approved these changes Oct 8, 2021

View reviewed changes

danielfmiranda merged commit a1ff286 into main Oct 8, 2021

danielfmiranda deleted the feature/BE-FE-spaces-cards branch October 8, 2021 20:52

wilhitem mentioned this pull request Oct 22, 2021

Mozfest: Update features to support localization #7673

Closed

Conversation

stevedya commented Sep 21, 2021 • edited by b-ggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions bot commented Sep 27, 2021

Uh oh!

github-actions bot commented Sep 27, 2021

Uh oh!

github-actions bot commented Sep 28, 2021

Uh oh!

github-actions bot commented Sep 28, 2021

Uh oh!

github-actions bot commented Sep 28, 2021

Uh oh!

github-actions bot commented Sep 29, 2021

Uh oh!

github-actions bot commented Sep 30, 2021

Uh oh!

github-actions bot commented Sep 30, 2021

Uh oh!

sabrinang commented Oct 4, 2021

Uh oh!

b-ggs commented Oct 5, 2021

Uh oh!

sabrinang commented Oct 5, 2021

Uh oh!

kristinashu commented Oct 5, 2021

Uh oh!

stevedya commented Oct 6, 2021

Uh oh!

sabrinang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 6, 2021

Uh oh!

github-actions bot commented Oct 6, 2021

Uh oh!

github-actions bot commented Oct 7, 2021

Uh oh!

stevedya commented Oct 7, 2021

Uh oh!

Pomax left a comment

Choose a reason for hiding this comment

Uh oh!

sabrinang left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

stevedya commented Sep 21, 2021 •

edited by b-ggs

Loading