[BE/FE] Mozfest Current Events Slider by b-ggs · Pull Request #7457 · MozillaFoundation/foundation.mozilla.org

b-ggs · 2021-09-23T12:54:30Z

Related PRs/issues #7429

Checklist

Did I squash my migration?

Screenshots:

Wagtail Admin:

UI:

sabrinang

requesting changes to see if it this makes the deployment active again

* Current events slider styles * Install swiper and style event cards * Break slider out of container * Adjust spacing and containers for wide templates and signup sidebar * Merge FE on to BE * Update source/sass/mozfest.scss Co-authored-by: janehughes <janeelizabethhughes@gmail.com> Co-authored-by: janehughes <janeelizabethhughes@gmail.com>

sabrinang

Type

Subheading link: follow .body size (18px/27px)

Layout

the left side of the slider crops/hides the content on tablet/desktop viewports, if the right breaks out of the container area the left should be seen too

if there is only one event item, can the arrows be hidden? (looks good on mobile where the indicator isn't present)

CMS
This might be content related but will there always be a subheading link because that field is required. It might be nice for that to be optional in case there isn't a "working group" link

Pomax

a few notes and questions

network-api/networkapi/mozfest/templates/mozfest/mozfest-base.html

network-api/networkapi/wagtailpages/pagemodels/customblocks/common/link_blocks.py

source/js/components/carousel/carousel.js

source/js/main.js

source/sass/main.scss

source/js/components/carousel/carousel.js

…-current-events-slider

…com:mozilla/foundation.mozilla.org into feature/be-fe-mozfest-current-events-slider

b-ggs · 2021-10-11T15:26:57Z

Subheading links are now not required.

I've also rebased from main and updated the migrations.

b-ggs · 2021-10-11T18:48:27Z

This is still pending frontend-related updates

github-actions · 2021-10-27T14:38:10Z

This PR introduces visual differences. Click here to inspect the diffs.

sabrinang

Thanks for making the updates to the weight and color!

Regarding the aligning blues, I found another different blue for the swiper-pagination-bullets let's use our dark-blue #0d10bf there

b-ggs · 2021-10-27T16:07:08Z

Thanks @sabrinang! Fixed the bullet color here: 9d06453

Pomax

Pomax

lookgs good to me =)

github-actions · 2021-10-27T16:44:43Z

This PR introduces visual differences. Click here to inspect the diffs.

sabrinang

👍 Great thank you for updating!

github-actions · 2021-10-27T20:38:06Z

This PR introduces visual differences. Click here to inspect the diffs.

b-ggs · 2021-10-29T09:10:02Z

The migration in this PR has been renumbered to 0025 in 6c49765!

github-actions · 2021-10-29T09:11:26Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-10-29T09:25:40Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-11-01T23:53:28Z

This PR introduces visual differences. Click here to inspect the diffs.

github-actions · 2021-11-04T15:24:28Z

This PR introduces visual differences. Click here to inspect the diffs.

mofodevops temporarily deployed to foundation-s-feature-be-mclwyx September 23, 2021 12:54 Inactive

wilhitem added this to the MozFest 2021 TBX milestone Sep 28, 2021

stevedya requested review from Pomax and sabrinang October 5, 2021 17:26

stevedya marked this pull request as ready for review October 5, 2021 17:32

sabrinang requested changes Oct 6, 2021

View reviewed changes

boggs and others added 5 commits October 7, 2021 04:37

Add common reusable link blocks

6d40c69

BE: Mozfest Spaces Cards

8776fcd

Update template size condition

569228b

Grid adjustment depending on signup form being visible

577d28a

b-ggs force-pushed the feature/be-fe-mozfest-current-events-slider branch from 6716938 to 577d28a Compare October 6, 2021 20:49

Pomax temporarily deployed to foundation-s-feature-be-fdo5h8 October 6, 2021 21:06 Inactive

b-ggs assigned Pomax and sabrinang Oct 6, 2021

sabrinang self-requested a review October 7, 2021 20:24

sabrinang requested changes Oct 7, 2021

View reviewed changes

Pomax suggested changes Oct 7, 2021

View reviewed changes

sabrinang mentioned this pull request Oct 7, 2021

[MozFest] Design support and review #7490

Closed

Javascript cleanups as per code review

18ac67c

mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 8, 2021 22:56 Inactive

boggs added 4 commits October 11, 2021 23:17

Merge remote-tracking branch 'origin/main' into feature/be-fe-mozfest…

371b181

…-current-events-slider

Update migrations

6a31577

Make subheading_link optional

2bf5e13

Merge branch 'feature/be-fe-mozfest-current-events-slider' of github.…

f3f2e04

…com:mozilla/foundation.mozilla.org into feature/be-fe-mozfest-current-events-slider

mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 11, 2021 15:26 Inactive

b-ggs requested review from Pomax and sabrinang October 11, 2021 15:28

sabrinang requested changes Oct 27, 2021

View reviewed changes

sabrinang mentioned this pull request Oct 27, 2021

[BE/FE] Mozfest Session Slider #7515

Merged

7 tasks

Change mobile navigation active bullet color to #0d10bf #7457 (review)

9d06453

mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 27, 2021 16:06 Inactive

b-ggs requested a review from sabrinang October 27, 2021 16:07

Pomax reviewed Oct 27, 2021

View reviewed changes

Pomax approved these changes Oct 27, 2021

View reviewed changes

sabrinang approved these changes Oct 27, 2021

View reviewed changes

Merge branch 'main' into feature/be-fe-mozfest-current-events-slider

05f63ad

mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 27, 2021 20:31 Inactive

Merge branch 'main' into feature/be-fe-mozfest-current-events-slider

f6cbbff

mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 29, 2021 09:08 Inactive

Update migrations

6c49765

mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 29, 2021 09:10 Inactive

Merge branch 'main' into feature/be-fe-mozfest-current-events-slider

6298337

mofodevops deployed to foundation-s-feature-be-fdo5h8 November 1, 2021 23:23 View deployment

Merge branch 'main' into feature/be-fe-mozfest-current-events-slider

a082403

Pomax temporarily deployed to foundation-s-feature-be-fdo5h8 November 4, 2021 14:53 Inactive

sabrinang mentioned this pull request Feb 7, 2022

Current Events Slider no longer full width on MozFest homepage #8131

Closed

tbrlpld mentioned this pull request Feb 8, 2022

Investigate why unexpected changes occurred on mozfest site #8132

Closed

Conversation

b-ggs commented Sep 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

sabrinang left a comment

Choose a reason for hiding this comment

Uh oh!

sabrinang left a comment

Choose a reason for hiding this comment

Uh oh!

Pomax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

b-ggs commented Oct 11, 2021

Uh oh!

b-ggs commented Oct 11, 2021

Uh oh!

github-actions bot commented Oct 27, 2021

Uh oh!

sabrinang left a comment

Choose a reason for hiding this comment

Uh oh!

b-ggs commented Oct 27, 2021

Uh oh!

Pomax left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pomax left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 27, 2021

Uh oh!

sabrinang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 27, 2021

Uh oh!

b-ggs commented Oct 29, 2021

Uh oh!

github-actions bot commented Oct 29, 2021

Uh oh!

github-actions bot commented Oct 29, 2021

Uh oh!

github-actions bot commented Nov 1, 2021

Uh oh!

github-actions bot commented Nov 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

b-ggs commented Sep 23, 2021 •

edited

Loading

Pomax left a comment •

edited

Loading