fix(agent-core-v2): stop warning on unhandled store.changed events - #3715
Conversation
|
|
@codex review |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1783894747
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Stop printing a spurious "[agent-core] unhandled event" warning when sending messages. |
There was a problem hiding this comment.
Remove the internal component name from the changeset
When this changeset is rendered into the public CLI release notes, it exposes the internal agent-core component label. Rephrase this as a neutral user-facing description, such as stopping spurious unhandled-event warnings when messages are sent.
AGENTS.md reference: AGENTS.md:L82-L82
Useful? React with 👍 / 👎.
1783894 to
d508d61
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Signed-off-by: 7Sageer <sag77r@hotmail.com>
Related Issue
N/A — internal fix, no tracking issue. Problem explained below.
Problem
Every message sent in the CLI prints console noise like
[agent-core] unhandled event "store.changed" in actor "x:271".The eventStore actor's publish fans each persisted event out two ways:
emitto external.on()subscribers (the real consumer path — works fine)and a sendBack to the agent machine. The agent machine declares
store.changedin its event types but defines no transition for it, so thexstate
reportUnhandledhook warns on the resulting zero-transitionmicrostep. Pure noise, no functional impact.
What changed
'store.changed': {}transition in the agentmachine (
packages/agent-core-v2/src/human/agent/machine.ts), mirroringthe existing
'store.reset': {}noop in the session machine — the machinenow explicitly acknowledges the event without reacting to it.
an unhandled-event warning.
xstate
waitForsnapshot re-evaluation, so the noop-transition approachwas chosen instead.
Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.