Skip to content

refactor(agent-core-v2): rename xstate inspection envelope ids to actorId and parentActorId - #3711

Merged
sailist merged 1 commit into
MoonshotAI:devfrom
sailist:refact-178-09-10-xstate-envelope-actor-ids
Sep 10, 2026
Merged

refactor(agent-core-v2): rename xstate inspection envelope ids to actorId and parentActorId#3711
sailist merged 1 commit into
MoonshotAI:devfrom
sailist:refact-178-09-10-xstate-envelope-actor-ids

Conversation

@sailist

@sailist sailist commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Related Issue

Internal follow-up to #3687 (no external issue).

Problem

The xstate inspection envelope streamed over /api/v1/debug/ws named the xstate actor's sessionId as actorSessionId, which collides with the existing agent session-id concept inside the codebase and makes the debug stream hard to read. The newly added parent field inherited the same problem as parentSessionId.

What changed

  • Renamed the envelope fields in XstateInspectionEnvelope: actorSessionIdactorId (still the xstate actor instance sessionId) and parentSessionIdparentActorId.
  • The previous actorId field (the user-facing actorRef.id) is kept under the new name refId to free up the actorId name.
  • Updated the two envelope assertions in machine.test.ts and wsUpgradeAuth.test.ts.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue (external PRs: the issue must have a maintainer's /approve).
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

@changeset-bot

changeset-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f2d60cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sailist
sailist merged commit 8072ee9 into MoonshotAI:dev Sep 10, 2026
13 checks passed
sailist added a commit that referenced this pull request Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant