feat(agent-core-v2): warn on [models] entries missing the model field - #3681
Merged
Conversation
🦋 Changeset detectedLatest commit: c0a432c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@codex review |
commit: |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
… models section Move collectMalformedModelEntries next to ModelRecordSchema and derive the known object-field set from the schema shape instead of hardcoding it, so future object fields cannot drift out of sync. Sections now contribute load-time diagnostics through a collectDiagnostics hook, mirroring the deprecations contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #3609
Problem
A
[models]entry written with an unquoted dotted TOML table name (e.g.[models.kimi-k2.7-code]) parses as nested tables, so the resulting entry has nomodel/namefield. Since #2981 / #3003 it no longer crashes, but it stays silently unusable: the picker shows the truncated alias and the entry only fails at selection time withModel "kimi-k2" must define a wire-facing name in config.toml., with nothing pointing at the actual mistake.What changed
collectMalformedModelEntries, a load-time collector that scans the raw[models]TOML entries and emits awarningconfig diagnostic for every entry missing bothmodelandname. When the entry contains a stray nested table (the tell-tale shape of an unquoted dotted alias, excluding the legitimateoauth/overridesobject fields), the message reconstructs the intended alias and shows the quoted form, e.g.[models."kimi-k2.7-code"].ConfigService.load()next tocollectKeyDeprecations, before the no-op-reload early return, so the warning surfaces through the existing diagnostics channel (TUI boot warnings,run-promptstderr, kap-server config warnings) and clears on reload once the entry is fixed.This follows the existing key-deprecation diagnostics path rather than adding a new surfacing mechanism, so all consumers pick it up for free.
Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.