fix(mcp): preserve distinct structured tool results - #3654
Merged
Conversation
🦋 Changeset detectedLatest commit: f88f2c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Related to #2554 and follows up on #3234's handling of duplicate MCP output.
Problem
An MCP tool can return a short summary in
contentand its records instructuredContent. The current adapter drops the records whenever content contains any usable text or media: a response saying “Found 1 row.” reaches the model without the row itself. The dropped data never reaches the tool-result spill pipeline.What changed
<in serialized extras instead of deleting closing-tag strings, so decoded field values remain unchanged.Human-readable renderings can overlap with structured data; they are retained because the adapter cannot establish that they preserve every field and type. Existing global spill retention limits and persistence-failure behavior remain outside this change.
Validation
pnpm --filter @moonshot-ai/agent-core-v2 test src/human/test/llm/thinking.test.ts— 15 tests passed after correcting an existing test listener fromllm.deltatollm.streaming.part. The requester already emits the latter; production behavior is unchanged.pnpm --filter @moonshot-ai/agent-core-v2 test test/agent/mcp test/mcpCore test/agent/toolExecutor test/agent/toolResultTruncation test/os/backends/node-local/tools/read.test.ts --disableConsoleIntercept --maxWorkers=4— 419 tests passed across 15 files.pnpm --filter @moonshot-ai/agent-core-v2 test test/agent/mcp/output.test.ts— 68 tests passed.pnpm --filter @moonshot-ai/agent-core-v2 typecheck— passed.pnpm --filter @moonshot-ai/agent-core-v2 lint:imports— passed.pnpm lint— passed with warnings and no errors.pnpm --dir docs run build— passed.Checklist
gen-changesetsguidance and included a CLI patch changeset.gen-docsguidance and synchronized the affected documentation withtranslate-docs.