feat(secondary-model): drop the experimental flag from the subagent model pool - #3634
Conversation
🦋 Changeset detectedLatest commit: 6f491f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@codex review |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b90cf0799
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return { model: own.modelAlias, thinking: own.thinkingLevel, modelSource: 'primary_override' }; | ||
| } | ||
| const pool = enabled ? resolveSubagentModelPool(config) : undefined; | ||
| const pool = resolveSubagentModelPool(config); |
There was a problem hiding this comment.
When users open the bundled browser UI with the normal default configuration, this now always resolves the secondary-model pool, but apps/kimi-code/dist-web/assets/index-CiHMlsuo.js still renders its secondary-model settings only when experimentalFlags["secondary-model"] or the legacy config override is true. Because removing the flag registration also removes that key from /api/v1/meta, the settings section disappears for most web users even though the backend feature is active; sync and commit the code-app bundle with this gate removed.
AGENTS.md reference: AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
3483b2f to
6f491f6
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
2 participants
Related Issue
None — follow-up to #3334, which flipped the pool on by default.
Problem
The subagent model pool (
[secondary_model]) has been enabled by default in every launch mode since #3334, but thesecondary-modelexperimental flag still gates it: the flag keeps showing up in/experiments, andKIMI_CODE_EXPERIMENTAL_SECONDARY_MODEL=0/[experimental] secondary-model = falsecan still turn the pool off. That keeps a second, rarely exercised behavior path alive (subagents inherit the caller's model, session startup skips pool validation) that config and tool code must keep branching on.What changed
Graduates the pool out of experimental entirely, following the file-history graduation in #3525:
secondary-modelflag definition and itsKIMI_CODE_EXPERIMENTAL_SECONDARY_MODELenv var; the pool is now always on. A leftover[experimental] secondary-model = falsein user config is ignored (the section is an open record), so no migration is needed.resolveSubagentBinding/exposesSubagentModelChoice/assertValidSubagentModelConfig/buildSubagentModelDescriptionsdropped theirflagsparameter;SessionSubagentService,TowerSpawnTool, and the models-validation service no longer injectIFlagService(the Agent/AgentSwarm tools keep it for the fork flag)./secondary-modelslash command no longer carriesexperimentalFlag, so it is always visible.update-configbuiltin skill.apps/kimi-code/dist-webfrom code-app with the settings-dialog gate removed (source change: kimi-code-app PR linked below); previously the subagents settings section keyed offexperimental_flags["secondary-model"]from/api/v1/metaand would have disappeared with the flag gone.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.