feat(agent-core-v2): add the L3 unit layer and the Feature seam - #2678
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f4825dd7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| private removeContribution(contribution: ConfigSectionContribution): void { | ||
| if (!this.foldDomains.delete(contribution.domain)) return; | ||
| this.unregisterSection(contribution.domain); |
There was a problem hiding this comment.
When two live units contribute the same config section (the fold treats identical duplicates as silent in registerSection), removing either record deletes the domain from foldDomains and unregisters the section even though another provider's record is still visible. That leaves the remaining feature/plugin's config as an unknown raw TOML section until it is re-added; refold or count surviving records instead of keying ownership by a single domain bit.
AGENTS.md reference: packages/agent-core-v2/AGENTS.md:L15-L15
Useful? React with 👍 / 👎.
| update: async () => { | ||
| await book.clear('unload'); | ||
| try { | ||
| run(); |
There was a problem hiding this comment.
For function/object recipes, FiberHandle.update(config) silently ignores the caller's new config because this callback accepts no argument and reruns with the closed-over initial config/facade. Any managed function unit updated through IFeatureManager.updateUnit(name, config) or a stored handle will restart with stale settings, unlike class and token units that revalidate and apply the new config.
AGENTS.md reference: packages/agent-core-v2/AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
| update: async () => { | ||
| await entry.dispose(); | ||
| if (this._book.isActive) { | ||
| this._book.effect(body, label ?? `effect:${this.name}`); | ||
| } |
There was a problem hiding this comment.
If a unit keeps the handle returned by this.effect(...) and calls update(), the replacement effect created here is not assigned back to the handle. The handle stays tied to the disposed entry (so state reports unloading and later dispose() only disposes the old entry), leaving the restarted effect alive until the whole unit book is torn down.
AGENTS.md reference: packages/agent-core-v2/AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
1020b43 to
3eab705
Compare
commit: |
3eab705 to
636d0c5
Compare
- introduce the L3 Service/Fiber unit layer: the Service base class with this.provide/effect/on/get/ref capabilities, the fiber runtime with thenable FiberHandles, collection contribution points, and the per-scope-kind ScopeUnits materialization fold - provide each scope's static registration batch as one atomic provideAll cascade transaction (waiting-area activation, sticky Failed on construction error) - add the DI unit inspection surface: App-scope debug ledger / dependency graph / cascade history services and the kimi-inspect DI view - add the Feature unit seam (IFeatureManager + feature assembly), port plan mode onto it, and add the contributed-command seam (agent-command domain + node-sdk RPC types) - remove the legacy dep-graph tooling - apply the header-only comment convention across src and test: strip non-header narration, keep the file header, tooling pragmas, and NOTE comments
…ections - add an opt-in target set in SessionEventBroadcaster; the global fan-out now skips event.di.* frames for connections that never opted in, so kimi-web and other clients no longer receive the high-churn DI feed - WsConnectionV1 opts a connection in when client_hello carries client_id 'kimi-inspect'; removeGlobalTarget drops the opt-in on close - temporary gate until a client-declared event-type whitelist lands
6612fb1 to
341d313
Compare
- build the live-ref container chain without aliasing this (no-this-alias) - snapshot the materialized map with Array.from and document why the copy is required (no-useless-spread)
The engine's LifecycleScope is a string enum now; the facade test doubles still returned the old numeric kinds and failed the handleWireSchema output validation.
…shotAI#2678) * feat(agent-core-v2): add the L3 unit layer and the Feature seam - introduce the L3 Service/Fiber unit layer: the Service base class with this.provide/effect/on/get/ref capabilities, the fiber runtime with thenable FiberHandles, collection contribution points, and the per-scope-kind ScopeUnits materialization fold - provide each scope's static registration batch as one atomic provideAll cascade transaction (waiting-area activation, sticky Failed on construction error) - add the DI unit inspection surface: App-scope debug ledger / dependency graph / cascade history services and the kimi-inspect DI view - add the Feature unit seam (IFeatureManager + feature assembly), port plan mode onto it, and add the contributed-command seam (agent-command domain + node-sdk RPC types) - remove the legacy dep-graph tooling - apply the header-only comment convention across src and test: strip non-header narration, keep the file header, tooling pragmas, and NOTE comments * feat(kap-server): gate the event.di.* debug feed to kimi-inspect connections - add an opt-in target set in SessionEventBroadcaster; the global fan-out now skips event.di.* frames for connections that never opted in, so kimi-web and other clients no longer receive the high-churn DI feed - WsConnectionV1 opts a connection in when client_hello carries client_id 'kimi-inspect'; removeGlobalTarget drops the opt-in on close - temporary gate until a client-declared event-type whitelist lands * chore(agent-core-v2): fix oxlint errors in the DI unit layer - build the live-ref container chain without aliasing this (no-this-alias) - snapshot the materialized map with Array.from and document why the copy is required (no-useless-spread) * test(klient): use string scope kinds in the lifecycle handle fakes The engine's LifecycleScope is a string enum now; the facade test doubles still returned the old numeric kinds and failed the handleWireSchema output validation. * build(nix): update the pnpmDeps fetch hash
1 participant
Related Issue
No linked issue — the problem is explained in the next section.
Problem
agent-core-v2 (the DI × Scope engine behind kap-server) gained its L0 ledger and L2 cascade engine in #2551, but scoped services were still plain constructor-injected registrations: a service could not provide other tokens, effects, or event subscriptions as one retractable unit; there were no contribution points for extending built-in domains (tools / agent profiles / config sections / wire vocabulary / commands) at runtime; and there was no introspection surface over the live container tree. Built-in capabilities such as plan mode were hard-wired into the agent domain instead of being composable, retractable features.
What changed
src/_base/di/): theServicebase class withthis.provide/effect/on/get/refcapabilities and two-phase construction, thenableFiberHandles (state/uid/update/dispose),collection<T>contribution tokens folded by consumer services, and the per-scope-kindScopeUnitsmaterialization fold.registerScopedServicebatch lands as ONE cascade transaction viaprovideAll— waiting-area activation, stickyFailedon construction error, seeds override static registrations.IDebugLedgerService/IDebugGraphService/IDebugCascadeService(unit tree, dependency DAG, cascade history, waiting area) served over the/api/v1/debugreflection, plus the kimi-inspect DI view with unprovide / update / dispose triggers.src/features/,src/app/feature/):IFeatureManagerassembles / updates / retracts dynamic units at runtime; plan mode is ported fromagent/plan+agent/tools/planonto the seam as the first Feature; the contributed-command seam (agent/command/, folded byIAgentCommandService) is surfaced through the node-sdk RPC types.scripts/dep-graph/).srcandtest: non-header narration stripped; file headers, tooling pragmas, andNOTE:comments kept.Checklist
packages/agent-core-v2/test/).gen-changesetsskill, or this PR needs no changeset — no changeset: the changes are agent-core-v2 internals and dev tooling (kimi-inspect), not user-perceivable in the CLI.gen-docsskill, or this PR needs no doc update — no user-facing CLI behavior change.