Skip to content

[Draft] Patch build-hardfork-package.sh against a bug in 1.4 #15486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2024
Merged

[Draft] Patch build-hardfork-package.sh against a bug in 1.4 #15486

merged 2 commits into from
Apr 9, 2024
+10 −1

Conversation

@georgeee
Copy link
Member

@georgeee georgeee commented Apr 8, 2024 •
edited
Loading

Which is fixed by PR #15462

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@georgeee georgeee requested a review from a team as a code owner April 8, 2024 21:39
@georgeee georgeee changed the title [Draft] Patch build-hardfork-package.sh against a bug in 1.4 which is fixed b… [Draft] Patch build-hardfork-package.sh against a bug in 1.4 Apr 8, 2024
@georgeee georgeee requested a review from a team as a code owner April 8, 2024 22:52
@georgeee
Use current time in verify-packaged-fork-config
b69d7ea 
Problem: it's not feasible to run the verification until the genesis
timestamp.

Solution: replace genesis timestamp with current time.
@georgeee georgeee force-pushed the georgeee/patch-build-hardfork-package.sh branch from c73ed57 to b69d7ea Compare April 8, 2024 23:17
@nholland94
Copy link
Member

!ci-build-me

1 similar comment
@deepthiskumar
Copy link
Member

!ci-build-me

@deepthiskumar
Copy link
Member

fork package successful https://buildkite.com/o-1-labs-2/hardfork-package-generation/builds/217

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit dc6bf78 into berkeley Apr 9, 2024
@deepthiskumar deepthiskumar deleted the georgeee/patch-build-hardfork-package.sh branch April 9, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nholland94 nholland94 nholland94 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@georgeee @nholland94 @deepthiskumar