Skip to content

Use release for fmt and mimalloc when multiple available, remove erroneous mimalloc 2 forcing #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikePopoloski merged 1 commit into from
Feb 24, 2026
Merged

Use release for fmt and mimalloc when multiple available, remove erroneous mimalloc 2 forcing #1680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions external/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ endif()

if(fmt_FOUND)
get_target_property(FMT_CFG fmt::fmt IMPORTED_CONFIGURATIONS)
get_target_property(FMT_LIB fmt::fmt IMPORTED_LOCATION_${FMT_CFG})
list(GET FMT_CFG 0 FMT_CFG_FIRST)
get_target_property(FMT_LIB fmt::fmt IMPORTED_LOCATION_${FMT_CFG_FIRST})
get_target_property(FMT_INC fmt::fmt INTERFACE_INCLUDE_DIRECTORIES)
message(STATUS "Found system fmt library: ${FMT_LIB}")
message(STATUS "Using system fmt include: ${FMT_INC}")
Expand Down Expand Up @@ -77,7 +78,7 @@ if(SLANG_USE_MIMALLOC)

set(find_pkg_args "")
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24.0")
set(find_pkg_args "FIND_PACKAGE_ARGS" "${mimalloc_min_version}")
set(find_pkg_args "FIND_PACKAGE_ARGS")
endif()

set(MI_OVERRIDE
Expand Down Expand Up @@ -117,8 +118,9 @@ if(SLANG_USE_MIMALLOC)
endif()

get_target_property(MIMALLOC_CFG ${mimalloc_target} IMPORTED_CONFIGURATIONS)
list(GET MIMALLOC_CFG 0 MIMALLOC_CFG_FIRST)
get_target_property(MIMALLOC_LIB ${mimalloc_target}
IMPORTED_LOCATION_${MIMALLOC_CFG})
IMPORTED_LOCATION_${MIMALLOC_CFG_FIRST})
get_target_property(MIMALLOC_INC ${mimalloc_target}
INTERFACE_INCLUDE_DIRECTORIES)
message(STATUS "Found system mimalloc library: ${MIMALLOC_LIB}")
Expand Down