Skip to content

Use release for fmt and mimalloc when multiple available, remove erroneous mimalloc 2 forcing#1680

Merged
MikePopoloski merged 1 commit into
MikePopoloski:masterfrom
timkpaine:tkp/up
Feb 24, 2026
Merged

Use release for fmt and mimalloc when multiple available, remove erroneous mimalloc 2 forcing#1680
MikePopoloski merged 1 commit into
MikePopoloski:masterfrom
timkpaine:tkp/up

Conversation

@timkpaine
Copy link
Copy Markdown
Contributor

  • Libraries may allow multiple available (as with vcpkg) in the form Release;Debug, so take the first if this is the case
  • The mimalloc min version part accidentally forces mimalloc 2, where 3 is widely available now

xref: microsoft/vcpkg#50116

@MikePopoloski
Copy link
Copy Markdown
Owner

mimalloc v3 is not fully production ready yet (the project says the current release is "rc3") which is why I hadn't updated yet. It's not generally safe to just take a different major version the project hasn't tested against, though for the case of mimalloc it's likely that things will build just fine.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.53%. Comparing base (1b521a3) to head (47fde9f).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1680   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files         235      235           
  Lines       53711    53711           
=======================================
  Hits        50776    50776           
  Misses       2935     2935           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b521a3...47fde9f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timkpaine
Copy link
Copy Markdown
Contributor Author

Just sharing for visibility, I'm going to patch for vcpkg and conda anyway

@MikePopoloski MikePopoloski merged commit 7fe219e into MikePopoloski:master Feb 24, 2026
19 checks passed
@timkpaine timkpaine deleted the tkp/up branch February 24, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants