Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Resolution Fails when attempting to add dependency with SPM #29

Closed
dimitri-nik opened this issue Jul 2, 2024 · 12 comments
Closed
Assignees

Comments

@dimitri-nik
Copy link

Hey! I've got an issue while trying to add the CameraView package to my project using Swift Package Manager. The package resolution is failing with the following error:

Failed to resolve dependencies Dependencies could not be resolved because root depends on 'cameraview' 1.2.0..<2.0.0.
unexpectedly did not find the new dependency in the package graph: sourceControl(identity: cameraview, location: SwiftPM.SPMPackageDependency.Sourc...

Xcode version 15.4
swift 5.0
ios 17.0

I tried clearing derived data and package caches
I recently added your PopUp package successfully

Not sure what else to try thanks!

@guytepper
Copy link
Contributor

guytepper commented Jul 4, 2024

Make sure to add https://github.com/Mijick/Timer as a dependency.

I think it's missing from the README? @FulcrumOne

@dimitri-nik
Copy link
Author

I added Timer as a dependency, but I'm still seeing the same issue 🤔

@guytepper
Copy link
Contributor

guytepper commented Jul 8, 2024

Can you post the full error you're getting? The error in your main post is truncated

Also, are you able to build your app, or this error prevents that?

@FulcrumOne
Copy link
Contributor

Sorry guys, I'll try to get back to this thread at the end of the day, I'm super busy fixing the problems from #26

@FulcrumOne FulcrumOne self-assigned this Jul 8, 2024
@dimitri-nik
Copy link
Author

Hey no issue building the app because I haven't added the package yet. The issue arises when I try to add the package through swift package manager in xcode. I started a fresh project added the Timer package successfully but when I try to add the CameraView this is what I see from spm:
Screenshot 2024-07-08 at 12 26 11 PM

@FulcrumOne
Copy link
Contributor

FulcrumOne commented Jul 8, 2024

@dimitri-nik, I was able to reproduce it. It seems that the problem only occurs in this configuration when importing the package:
CleanShot 2024-07-08 at 23 59 41

To fix this, just select branch main here
CleanShot 2024-07-08 at 23 59 51

Let me know if it solved your problem 😉

@dimitri-nik
Copy link
Author

This solved my problem thank you!! 🙌

@FulcrumOne
Copy link
Contributor

@dimitri-nik, glad to hear it!

@guytepper thanks for your help as well! 😉

@guytepper
Copy link
Contributor

@FulcrumOne isn't the issue with this solution, to get the latest commits from the main branch, that it enforces the library to be updated even if that's not intentional? For example, breaking changes could be introduced.

@FulcrumOne
Copy link
Contributor

@guytepper unfortunately it slipped my mind when publishing this update and I'm very sorry for this😕

I promise to introduce the fix in the upcoming update.

Thanks for your comment and have a good day,
Tomasz

@FulcrumOne FulcrumOne reopened this Jul 15, 2024
@FulcrumOne
Copy link
Contributor

@guytepper here's the roadmap for this library.

Feel free to create a ticket if you need some new feature to be introduced 😉

@FulcrumOne FulcrumOne mentioned this issue Jul 27, 2024
FulcrumOne added a commit that referenced this issue Jul 28, 2024
feat:
- Added possibility to customise DefaultCameraView (#33)
- Added option to change camera frame rate (#28)
- Extended ability to customise behaviour after media capture (#34)
- Added ability to change camera resolution

fix:
- Fixed problem with package manager (#29)
@FulcrumOne
Copy link
Contributor

@guytepper, @dimitri-nik

Version 2.1.0 resolves this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants