App lifecycle problems

[clbemre]

Hello, firstly this is a great framework.

I have a problem. When the application goes to the background and comes to the front again, the image or video preview closes and returns to the shooting screen, this is a problem, the second problem is that when I try to shoot again after this scenario, I get a crash.

Why doesn't the app continue where I left off when I put it in the background and then bring it back to the foreground?

var cameraView: UIView { cameraLayer.superview ?? .init() } -> and i get a crash for take a picture after background/foregroung. Because I guess CameraInputView is being recreated.

Thank you

[FulcrumOne]

Hey @clbemre, thanks for this ticket!

I'm currently busy developing an update for our other library (NavigationView), but I'll be back here as soon as I finish that task (probably at the end of this week).

I hope it suits you, thanks again for your ticket and have a nice day,
T.K.

[clbemre]

Hello again @FulcrumOne, thank you for your interest.

Additionally, when there is a CameraPreview screen displayed, if I display an alert on the screen with MJCameraController().alert { }, the CameraPreview closes. I want to maintain its state and prevent the preview screen from closing unless I close it myself. I get the same alert problem if I present it with .alert {} in Camera Preview.

The alert appears on the preview screen, but this situation when the cancel button is pressed. So, disappeared preview screen.

I think this alert problem and the background/foreground problem of the application that I mentioned before are caused by the same problem.

---

Additionally, I’m just curious, why do you use DispatchQueue.main.async { [self] in } instead of DispatchQueue.main.async { [weak self] in } ?

[clbemre]

Hello again @FulcrumOne, when will you fix these issues? or will?

Thank you.

[FulcrumOne]

hey @clbemre,

Sorry, had a lot of work related to our other libraries. In my calendar, work on this library is scheduled to start this Thursday

Apologies for the "communication issues" once again; I believe creating a Discord / Slack channel would help us stay better connected and updated on things related to libraries. I'll try to organize it this week 😉

Have a great day,
Tomasz K.

[clbemre]

Thank you @FulcrumOne , I will be waiting for your response.
Thank you for your interest. 🙏🏻

Have a nice day.
Best Regards

[clbemre]

Hello again, @FulcrumOne , have you started this issues solutions? I'm sorry for bothering you but its a little important for me :)
Thank you again.

[FulcrumOne]

Hey, I'm starting this evening😉 Hope it will be ready by the weekend

[clbemre]

This is great! Thank you :) Good luck :)

[FulcrumOne]

Hello, firstly this is a great framework.

I have a problem. When the application goes to the background and comes to the front again, the image or video preview closes and returns to the shooting screen, this is a problem, the second problem is that when I try to shoot again after this scenario, I get a crash.

Why doesn't the app continue where I left off when I put it in the background and then bring it back to the foreground?

var cameraView: UIView { cameraLayer.superview ?? .init() } -> and i get a crash for take a picture after background/foregroung. Because I guess CameraInputView is being recreated.

Thank you

hey @clbemre, just to confirm - you're telling that you experienced a crash when you backgrounded the app and then returned to the foreground, correct?

[FulcrumOne]

@clbemre, that second problem (with alert and crash I was able to reproduce, so I'll start from this one)

[clbemre]

Hello again @FulcrumOne
First of all, there are a few problems; after the first startup, it puts it in the background without doing anything, and when it comes back to the foreground, it crashes while trying to take a photo/video. Then, after showing an alert while on the preview screen, both the preview screen disappears and when I try to take a photo or video again, it crashes again, and sometimes it is because of the cameraView superView and sometimes it is because of the blurViews, but I think the problem is common, because as far as I understand, the camera manager is deinit/init and the swiftUI randomly appears on the screen. because of their renderings.

Additionally , independently of these, the snapshot and blurview you showed while flipping the camera are turned landscape.

Sorry for my english, sometimes i use translate :)

[FulcrumOne]

hey @clbemre,

No problem, English is not my native language either (it would be nice if we both spoke Polish 😅)

Could you please test the branch called 'patch-1.2.1', it should fix your problem with alert that causes the app to crash?
You should also add this method to your MCameraController - .equatable() (it's a temporary solution)

[clbemre]

Hey @FulcrumOne this temporary solution works. Thank you. 💪🏻 (we can't speak Polish, I'm Turkish 😀)
Are we going to continue with this temporary solution or are you continuing to work on resolving the issue at its base? As far as I can see, you are working on memory leaks in particular.

[FulcrumOne]

hey @clbemre, thanks for letting me know!

I want to spend some time today and check the library for problems with memory leaks, and then I will move on to fixing this issue with the background mode.

[clbemre]

Hey @FulcrumOne , also we have a little problem :) when First launch MCameraController, the system want to permission. If I deny the system permission, the UI does not update and switch to the error view, the camera layer visible black view.

[FulcrumOne]

@clbemre I'll have to spend little more time on this task, as the problem is little bigger than I initially thought; there are several problems that I discovered today. I'll keep you in the loop😉

[clbemre]

okey @FulcrumOne thank you for your response. I'll be wating for you. Good luck :)

[FulcrumOne]

Hey @clbemre,

So we have two potential solutions to our problem:

1. We can move CameraManager to the level above (i.e. the parent view in which MCameraController is implemented, managed by the developer). Additionally if we opt for this option, I would also like to move the functions from the Public+MCameraController file lines 15 -> 43 to the CameraManager initialiser.
2. We can make CameraManager singleton; this will allow us to avoid major changes to the public API, however, there may be some issues when trying to port the library to iPadOS and macOS.

Therefore, I think that, in the long term, a better solution will be to implement point 1. What do you think?

[FulcrumOne]

@clbemre,

The branch named patch-1.2.1-beta contains fixes to the following problems:

1. MCameraController and error screen
2. Alert interrupting camera session
3. Memory leaks when app switches to and from the background mode

[FulcrumOne]

Hello, firstly this is a great framework.

I have a problem. When the application goes to the background and comes to the front again, the image or video preview closes and returns to the shooting screen, this is a problem, the second problem is that when I try to shoot again after this scenario, I get a crash.

Why doesn't the app continue where I left off when I put it in the background and then bring it back to the foreground?

var cameraView: UIView { cameraLayer.superview ?? .init() } -> and i get a crash for take a picture after background/foregroung. Because I guess CameraInputView is being recreated.

Thank you

I cannot reproduce this problem unfortunately. However, there is a chance that this branch has already fixed the issue. If not, please let me know

[clbemre]

@FulcrumOne Hello, Is the temporary solution not sufficient at the moment?
Also I think long term solution is better.

• patch-1.2.1-beta solutions is finished or will?

• var cameraView: UIView { cameraLayer.superview ?? .init() } -> It got resolved after applying the equatable() workaround.

• Actually after I applying the equatable() all problems resolved. I guess just have a little memory leak, thats all.

[FulcrumOne]

Additionally , independently of these, the snapshot and blurview you showed while flipping the camera are turned landscape.

I'm working on this now. If you need a faster solution, I strongly recommend locking the rotation for the current screen (lockOrientation method).

[clbemre]

Additionally , independently of these, the snapshot and blurview you showed while flipping the camera are turned landscape.

I'm working on this now. If you need a faster solution, I strongly recommend locking the rotation for the current screen (lockOrientation method).

I noticed this about this problem. When I tested it on the iPhone X, it rotates, but when I tested it on the iPhone 11 Pro Max, it does not rotate. I also completely turned off the device rotation, it only works in portrait mode.

[FulcrumOne]

@FulcrumOne Hello, Is the temporary solution not sufficient at the moment? Also I think long term solution is better.

• patch-1.2.1-beta solutions is finished or will?
• var cameraView: UIView { cameraLayer.superview ?? .init() } -> It got resolved after applying the equatable() workaround.
• Actually after I applying the equatable() all problems resolved. I guess just have a little memory leak, thats all.

This temporary solution was a bit unstable and caused other problems (the error screen was not displayed for example). I would therefore recommend using the patch-1.2.1-beta branch 😉

[clbemre]

@FulcrumOne Hello, Is the temporary solution not sufficient at the moment? Also I think long term solution is better.

• patch-1.2.1-beta solutions is finished or will?
• var cameraView: UIView { cameraLayer.superview ?? .init() } -> It got resolved after applying the equatable() workaround.
• Actually after I applying the equatable() all problems resolved. I guess just have a little memory leak, thats all.

This temporary solution was a bit unstable and caused other problems (the error screen was not displayed for example). I would therefore recommend using the patch-1.2.1-beta branch 😉

Okey I will, thank you for your interest and for this great library :)

[FulcrumOne]

Thanks! If you have any further problems, let me know😉

PS. Check out our other solutions too!

[clbemre]

Hello @FulcrumOne , So now we can create MJCameraController(manager: .init()), is it correct?

Additionally, when Camera first opened, Flip transition and back/front camera transition works very slow now(I think there is too much UI rendering going on). Also, there is a delay when opening for the first time and it opens late.

I'm not sure but I think when I click the apply media button while on the preview screen. the UI freezes for a while because I show an alert after clicking apply, normally it would appear immediately, now it appears after a few seconds, I think the UI is not rendering. Also, when i preview video screen and i have a alert, alert is gone when replayed video. There is too much rendering issue.

Actually, just the .equatable() temproray solution works nicely. Whats problem for .equatable() solutions.

[clbemre]

@FulcrumOne and , I applied patch-1.2.1-beta. but if i remove Equatable and .equatable() modifier, still i am getting crash, I guess, its have to stay, is it correct?

I’m just curious, why do you use DispatchQueue.main.async { [self] in } instead of DispatchQueue.main.async { [weak self] in } ? :)

[clbemre]

@FulcrumOne I have checked just before and applied. But still;

• grid not visible ❌ ( maybe i have missed one thing, i don't know :/ )
• UI freezing works correct ✅ ( Im not sure but i guess rarely works wrong)
• first open is fast now ✅
• flip rotate animation works correct. ✅

thank you 🙏🏻

[clbemre]

sorry, also The UI update failure error regarding system permission deny also persists.

[FulcrumOne]

Ok, I was able to see the second problem, but the one with the invisible grid I still cannot debug

Give me five minutes, I'll fix the problem with error screen and then we'll focus on the grid.

[clbemre]

I have tried it on 2 different real devices, the grids do not appear neither at the first init method nor with the on/off grid button. 😬

[clbemre]

I'm sorry :/ but Also, something like this happens, I start recording a video and the screen refreshes at that moment and the video starts recording, normally it would start directly. But now, because the screen is refreshing, the frame before I press the button appears on the screen momentarily and disappears, a UI bug. 😥

[FulcrumOne]

could you show me a video please?

[clbemre]

RPReplay_Final1720443778_480.mov

@FulcrumOne
Sometimes a much more distinct view appears on the screen.

[clbemre]

(Deleted Video)

@FulcrumOne

I took a more clear video, focus on the bottom left corner and notice a momentary view appearing and disappearing. , can you take a quick look? because I'm going to delete it :D

[FulcrumOne]

sorry, also The UI update failure error regarding system permission deny also persists.

should be fixed now

[FulcrumOne]

346579937-05f85df7-9dd4-4dc5-86ba-504aab3c5cd4.mov

@FulcrumOne

I took a more clear video, focus on the bottom left corner and notice a momentary view appearing and disappearing. , can you take a quick look? because I'm going to delete it :D

Oh, now I see it. i'll try to fix it this night, and if I don't fix it then, I'll have to move it to Wednesday unfortunately😉

[clbemre]

@FulcrumOne okey thank you again 🙏

[FulcrumOne]

Btw, just to be sure, because the both problems (invisible grids and flashing views) are not present in demo app I'm using for testing; are you sure it's not caused by some UI elements of your app?

And if so, could you please prepare the code for me that I can use to reproduce the bug? Thanks in advance! 😅

[clbemre]

I can check again, but firstly could you send me your demo project ?

[FulcrumOne]

@clbemre,

https://github.com/Mijick/CameraView-Demo, branch patch-2.0.0

[clbemre]

@FulcrumOne Hey I have found issue, The problem was caused by me, when I pressed the record button, I was setting captureSession.sessionPreset = .hd1280x720. This was causing a rendering problem on the screen. It was fixed when I deleted the code. Also, the system permission alert problem and the gird visibility problem were solved. Everything is perfect now, thank you very much for your interest. We don't have any other problems that I know of. 🙏🏻🙏🏻

[FulcrumOne]

@clbemre,

I'm super glad to hear it! I'll fix some other bugs I noticed and release version 2.0.0. Thanks for your support and see you soon!⚡️

[clbemre]

Thank you. 🙏 I’ll be waiting for 2.0.0 :) Good luck

Have a nice day.

[clbemre]

Hello again @FulcrumOne , in CameraManager, you add observers but you don't remove. maybe you can add
deinit{
NotificationCenter.default.removeObserver(self, name: .AVCaptureSessionWasInterrupted, object: captureSession)
}

or

Do you have any spesific reason you don't remove observer?

[FulcrumOne]

@clbemre,

Ahh, you're literally a life saver. I totally missed it. Thanks!

[clbemre]

@FulcrumOne

Haha, every time, thank you too:)

[FulcrumOne]

@clbemre,

Fixed! I also changed the rotation animation a bit + fixed some other issues. Could you please check the latest commits and give me your feedback? Thanks a lot!

PS. The version was published to the main branch ;)

[clbemre]

@FulcrumOne Hey, I'll check as soon as. Thank you for the information.

[clbemre]

@FulcrumOne Hello again, everything is good. but just i want to say something.

When I rotate to landscape mode my phone, the camera lens changes and goes into close-up mode. It would be better if this was optional, because I don't want it to go into close-up mode when I rotate it landscape. If there is a option, I don't know, I didn't see. :) Other than that, everything is fine, well done.

[FulcrumOne]

Hey, could you show me the video of the problem you described? Thanks!

[clbemre]

@FulcrumOne Sorry I had turned some things off. So I couldn't re-run the error scenario. If I encounter this error again, I will let you know.

[FulcrumOne]

@clbemre, thanks!