Azure Application Insights SpringBoot Starter #646

dhaval24 · 2018-04-12T23:42:16Z

This PR introduces a final version of Azure Application Insights SpringBoot starter. It extends on the work done in #518 by @gavlyukovskiy.

The starter closely has all the required functionalities and tuning knobs that ApplicationInsights.xml file provides to the user using application.properties and spring dependency injection.

The core additional functionality which are added on the Top of #518 are as follows:

Autoconfiguration of performance counter properties (collection interval etc.)
Autoconfiguration of JVM Counters
Autoconfiguration of JMX counters
Autoconfiguration of Heartbeat
Autoconfiguration of Cloud_RoleName (helps in logical representation of micro-service) Spring Boot Starter for Java SDK: auto-configure cloud_roleName #643

It also removes all field injection and instead now uses constructor injection and setter injection as recommended by Spring.

Thank you @gavlyukovskiy for your very vital contribution to our project.

Note: This should not be merged until #631 is merged. Once #631 is merged -> merge master in this branch resolve API changes and then merge.

For significant contributions please make sure you have completed the following items:

Design discussion issue #
Changes in public surface reviewed
CHANGELOG.md updated

Clarified all default values in readme; Changed default logging level to error; Added @ConditionalOnWebApplication for web configurations.

…num for property auto complete

…d readme.

…in spring boot starter

# Conflicts: # core/src/main/java/com/microsoft/applicationinsights/channel/concrete/inprocess/InProcessTelemetryChannel.java # core/src/main/java/com/microsoft/applicationinsights/internal/channel/common/TransmissionFileSystemOutput.java # core/src/main/java/com/microsoft/applicationinsights/internal/channel/common/TransmissionNetworkOutput.java # core/src/test/java/com/microsoft/applicationinsights/internal/channel/inprocess/InProcessTelemetryChannelTest.java

Added application insights starter for spring boot

…n to be created first

…plicationInsights-Java into spring-boot-starter

…tTags are not reflected on UX if not in bond schema definition

…on for JMX counters and JVM counters

dhaval24 · 2018-04-24T22:28:59Z

.../java/com/microsoft/applicationinsights/boot/ApplicationInsightsWebMvcAutoConfiguration.java

+        FilterRegistrationBean registration = new FilterRegistrationBean();
+        registration.setFilter(webRequestTrackingFilter);
+        registration.addUrlPatterns("/*");
+        registration.setName("webRequestTrackingFilter");


This should not be hardcoded.

@littleaj and @grlima I looked into this method. This is method is usually used to set the name of the RegistrationBean, however it is not necessary to set the name and the default behavior here is that if this is not set explicitly the name of the bean would be taken into the account.

Further, a surprising thing this method no longer seems to be present in the latest SpringBoot framework however no mention anywhere in the change logs too.

spring-projects/spring-boot@9cb5f3d#diff-4c7df2b424db8ecb8e18ac9485ddcc8d

Therefore just to be safe i would remove it. Anyways, it doesn't affect the behavior either.

makes sense

littleaj · 2018-04-25T19:41:25Z

.../java/com/microsoft/applicationinsights/boot/initializer/SpringBootTelemetryInitializer.java

+ *
+ * @author Dhaval Doshi
+ */
+public class SpringBootTelemetryInitializer implements TelemetryInitializer {


Would someone want to use this having a spring boot app but not using the starter?

If so, an argument could be made to move this under the core project. Of course, that means removing the @Value annotation.

I would break it into two parts:

Would someone like to use AI with SpringBoot without starter? : Possibility, relatively very slim though.

Can we move this to core? - I don't think so because we cannot distinguish if the app is of type springboot in the core and then downstream methods would fail. Further, I think this is nice separation of logics. I think spring related stuff should be at one place.

littleaj · 2018-04-25T19:46:15Z

.../com/microsoft/applicationinsights/channel/concrete/inprocess/InProcessTelemetryChannel.java

@@ -21,15 +21,11 @@

 package com.microsoft.applicationinsights.channel.concrete.inprocess;


It is really hard to see what has changed here.

Please reduce the amount of code style changes here so we can easily locate the functional changes.

Sure in my recent commit I have tried to do that.

@dhaval24, What has functionally changed here? I'm only seeing whitespace changes. If nothing has changed related to spring boot starter, please revert this.

@littleaj There is a new public constructor in this. In addition there are some member variables which are converted to public.

As much as I dislike the additional changes in this file....this should be fine. If you can find time to fix this, please do.

littleaj · 2018-04-25T19:47:15Z

...om/microsoft/applicationinsights/extensibility/initializer/SdkVersionContextInitializer.java

@@ -21,11 +21,9 @@

 package com.microsoft.applicationinsights.extensibility.initializer;

-import com.microsoft.applicationinsights.internal.logger.InternalLogger;
+import com.microsoft.applicationinsights.extensibility.ContextInitializer;


Unnecessary change...

I think this change is only about removing unused import. Why it's unnecessary? They are overhead.

We can do style clean-up in a separate PR.

I think there is no harm touching some files here. I agree big changes can go separately, this is just a import removal :)

Sure. I'm fine with fixing some style issues here and there, but try to keep it contained to files which are related to the feature.

That way, if we want a list of files having to do with this feature, we can simply look at files changed in this PR or the squashed commit. Having this here makes the git history look like this file has something to do with the spring boot starter.

@littleaj I agree with you on this. I have tried to reduce majority of styling things at other places too.
#resolved

This is not resolved.... please revert since it's has no relevance to this feature.

@littleaj I thought we had discussed that since this was only an import removal, it was fine. If this opinion has changed and you think that we should keep the additional import then I can bring it back. In my opinion, we rarely get chance to work on code cleaning and small changes (which do not affect the logic should be fine). While I do understand your concern for clean history this should not be something which is too big of change. @grlima what are your thoughts? If you both agree on reverting this small change I can do that.

@littleaj I have reverted this file. Thanks fore your concerns on separating the logic.

littleaj · 2018-04-25T19:51:50Z

web/src/main/java/com/microsoft/applicationinsights/web/internal/WebRequestTrackingFilter.java

-                    // chomp
-                }
-            }
+        //If Agent Jar is not present in the class path skip the process


This shouldn't change. Spring Boot Starter has nothing to do with detecting the agent. Does it?

Well this is a bug in-itself. We write unnecessary log message and discover the agent in a very poor way. I think we discussed about this in past. Not sure if you remember it though and we had debugged through it too.

#579

Detecting the agent is an important part of our current functionality. It could be better, but it's a separate issue. It should be a separate PR.

I agree it's a seperate issue, but I would much rather prefer to have it fixed along with this roll out. If required this can be branched out of this PR, but changes need to be there when the starter rolls out otherwise we get a lot of superfluous error messages. I believe you would agree with this.

We should address it separately. I made some comments in #579. I'd like to have a separate discussion regarding this change.

I reverted this changes. I will submit another PR for this changes. #resolved

littleaj · 2018-04-25T19:58:54Z

.../microsoft/applicationinsights/internal/channel/inprocess/InProcessTelemetryChannelTest.java

+
+    @Test
+    public void testInProcessTelemetryChannelWithDefaultSpringBootParameters() {
+        new InProcessTelemetryChannel("https://dc.services.visualstudio.com/v2/track", "10",


I see there are other tests that follow this pattern, but I'd rather not continue to use it.

Checking the constructor doesn't throw is good, but we should assert on the effects the parameters have on the resulting object; e.g. assertEquals(theGivenEndpoint, channel.getEndpoint()); I don't know if that method exists, but you get the idea.

@littleaj I think this can be refactored but then we might need to use reflection to test the values of InProcessTelemetryChannel. Do you prefer it?

No, don't worry about it. This is fine for now. I didn't realize it didn't have accessors for most fields. Perhaps we can add accessors in the future or make the class not final.

littleaj · 2018-04-25T20:05:12Z

...oft/applicationinsights/internal/channel/samplingV2/FixedRateSamplingTelemetryProcessor.java

-    private static final String pageViewTelemetryName = "PageView";
-    private static final String requestTelemetryName = "Request";
-    private static final String traceTelemetryName = "Trace";
+    public static final double DEFAULT_SAMPLING_PERCENTAGE = 100.;


trailing dot is syntactically correct? if so, there's nothing wrong here. I just didn't know that 😄

Doesn't fail, but probably typo. I don't know either. I will make it 100.0 :)

Probably for the best. It's an easy character to miss if you're skimming.

littleaj · 2018-04-25T20:07:50Z

...oft/applicationinsights/internal/channel/samplingV2/FixedRateSamplingTelemetryProcessor.java


-    private static Map<String, Class> allowedTypes;
+    static {


I'm fine with moving this to the static constructor, but changing the map type is unnecessary. We don't need to introduce parsing into this. String.hashCode does a fine job here.

By doing this IDE can perform auto-complete when users are typing this properties. That was the reason of this change. Providing recommendation is a good value addition. It would avoid people to look into docs multiple times and switch screens.

@dhaval24, let's discuss offline

@littleaj I have given some deep thoughts on this, and I think I would agree with you on this. Here are the reasons: This enum is only used for the sampling, not required elsewhere. It adds an overhead of maintaining it and ensuring that all new types are also added to it. A person can easily miss this unless there is an automated way to do it. Further more this enum is public which then adds the overhead of not deprecating it before a major version. The degree of advantage it provides is not absolute necessity and overhead is pretty high.

I will make this changes :) Thanks for drawing the attention.

littleaj · 2018-04-25T20:09:08Z

...c/main/java/com/microsoft/applicationinsights/internal/channel/samplingV2/TelemetryType.java

@@ -0,0 +1,19 @@
+package com.microsoft.applicationinsights.internal.channel.samplingV2;


See comment in FixedRateSamplingTelemetryProcessor. This should be removed.

See my response above for it.

Will be amended based on my response above.

littleaj · 2018-04-25T20:12:17Z

...va/com/microsoft/applicationinsights/boot/HeartBeatProvider/SpringBootHeartBeatProvider.java

+ *
+ * @author Dhaval Doshi
+ */
+public class SpringBootHeartBeatProvider implements HeartBeatPayloadProviderInterface {


Is it possible to extend the implementation in core? or make it a delegate? You shouldn't need to reimplement the whole class.

Well I think no. The design for this is such that, each separate functionality has it's own HB provider. For example springboot has it's own, Azure VM will have it's own and WebApps have it's own. This provides the flexibility for user to turn off the whole provider in itself incase if they do not need it rather then handpicking each properties to disable. The contract each Provider has to follow is to implement the interface. I think this provides nice abstraction, separates the module in itself from core and lets us be able to freely modify it without affecting others.

Ok, i see. This is sending spring boot specific data; a decorator of heartbeat events. Makes sense.

littleaj · 2018-04-25T20:13:11Z

core/src/main/java/com/microsoft/applicationinsights/TelemetryConfiguration.java

+     * @return {@link com.microsoft.applicationinsights.TelemetryConfiguration}
+     */
+    public static TelemetryConfiguration getActiveWithoutInitializingConfig() {
+        synchronized (s_lock) {


null check?

Good catch :) will add it.

littleaj · 2018-04-25T21:28:02Z

My main concern is that we've essentially reimplemented configuration loading for the spring boot case.
If there's a way to refactor this so we don't need as much "populate the config object" code and use what is already in core, that would be beneficial for future maintenance and support of this code.

If not, there needs to be a test which creates a configuration object the normal way and an equivalent object in the spring boot way to make sure the spring boot code path makes the same object.

gavlyukovskiy · 2018-04-26T18:02:54Z

...main/java/com/microsoft/applicationinsights/boot/ApplicationInsightsModuleConfiguration.java

+    public HeartBeatModule heartBeatModule(Environment environment) {
+        try {
+            HeartBeatModule heartBeatModule = new HeartBeatModule();
+            HeartbeatDefaultPayload.addDefaultPayLoadProvider(new SpringBootHeartBeatProvider(environment));


If it's expected from users to be able to provide own HeartBeatProvider implementation it's worth to create bean:

@Bean @ConditionalOnMissingBean public HeartBeatPayloadProviderInterface heartBeatPayloadProviderInterface(Environment environment) { return new SpringBootHeartBeatProvider(environment); }

and inject HeartBeatPayloadProviderInterface into HeartBeatModule. It's important to have interface declaration instead of implementation - SpringBootHeartBeatProvider because only this way users are able to override the bean.

In all cases we would like to have the properties of the current provider for better assessment. However it makes sense to do this more elegantly using bean. I would refactor this.

@gavlyukovskiy this is now addressed.

…arter accordingly, making HeartBeatPayloadProviderInterface bean, fixing critical issue with sampling configuration

This reverts commit bc19586.

dhaval24 · 2018-05-04T16:49:32Z

I wanted to point out the following: By reverting the changes of how agent is detected to the original implementation, the user will see this misleading exception message when the Agent Jar is not present.

AI: ERROR 04-05-2018 09:08:53.150, 31(localhost-startStop-1): Could not find Agent: 'java.lang.NoClassDefFoundError: com/microsoft/applicationinsights/agent/internal/coresync/AgentNotificationsHandler
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at com.microsoft.applicationinsights.internal.agent.AgentConnector.register(AgentConnector.java:79)
at com.microsoft.applicationinsights.web.internal.WebRequestTrackingFilter.registerWebApp(WebRequestTrackingFilter.java:287)
at com.microsoft.applicationinsights.web.internal.WebRequestTrackingFilter.initialize(WebRequestTrackingFilter.java:263)
at com.microsoft.applicationinsights.web.internal.WebRequestTrackingFilter.init(WebRequestTrackingFilter.java:145)
at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:285)
at org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:112)
at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4590)
at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5233)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1419)
at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1409)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: com.microsoft.applicationinsights.agent.internal.coresync.AgentNotificationsHandler
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 27 more

IMO, this is very confusing and I can remember couple of tickets when users pointed out to this weired behavior.

My suggestion : We can take two approaches -

Either avoid dumping stackTrace for this scenario. (Caution: We will also miss any other exceptions which might come up here).
Change the way how agent is detected. I will submit another PR as requested.

My opinion will hinge towards second suggestion, because effectively when a runtime exception is thrown compiler has to jump instructions which makes the program terribly slow. You can look at more details on this thread (https://stackoverflow.com/questions/299068/how-slow-are-java-exceptions)
Further, users expect exceptions when a bad behavior happens in the program, not for what is expected to be usual behavior. This is also considered seriously bad practice. I would strongly urge to have a better way for detecting agent. I propose one in another PR, if there is a better alternative I am happy to evaluate it.

… version number to HB telemetry

dhaval24 · 2018-05-13T20:09:12Z

Modularized the way to specify version number for starter and added the Starer version in HeartBeat payload for better diagnosis.

dhaval24 · 2018-05-14T22:11:30Z

...oft/applicationinsights/internal/channel/samplingV2/FixedRateSamplingTelemetryProcessor.java

    private static final String eventTelemetryName = "Event";
    private static final String exceptionTelemetryName = "Exception";
    private static final String pageViewTelemetryName = "PageView";
    private static final String requestTelemetryName = "Request";
    private static final String traceTelemetryName = "Trace";

-    private static Map<String, Class> allowedTypes;
+    static {


@littleaj dual initialization is now fixed.

dhaval24 · 2018-05-15T01:09:24Z

@littleaj @grlima I have added tests discussed which shows similarity between traditional XML based configuration and Springboot configuration. Let me know if there is anything else which needs to be taken care here.

grlima

Reviewed offline with stakeholders.

) * smoke test for SpringBoot * smoke test app springboot * trying java 7 * trying source and target compatibility * fixing assert * enabling the temporarily disbabled smoke tests * Reverting temporary adjustments

gavlyukovskiy and others added 30 commits January 9, 2018 02:26

Added application insights starter for spring boot

9bc3711

Added a way to disable default modules, added documentation and readme

dd97415

Polish readme

cce54ae

Added properties to disable quick pulse integration, all web modules;

946f04a

Clarified all default values in readme; Changed default logging level to error; Added @ConditionalOnWebApplication for web configurations.

Fixed bean ordering issue

91f112b

Added properties for channel and new sampler, created TelemetryType e…

abeff08

…num for property auto complete

Added documentation to added properties, added default values, update…

e8f688f

…d readme.

Changed sampling configuration, added more tests for autoconfiguration

ed16e55

Changed constants with default values to public in order to use them …

83e1554

…in spring boot starter

Added explicit dependency on TelemetryConfiguration for QuickPulse bean

b55c467

Polish

afe1d0c

Updated documentation regarding configuration values window

62086f3

Updated documentation of properties

a4fda92

Merge pull request #518 from gavlyukovskiy/spring-boot-starter

77d88a6

Added application insights starter for spring boot

Merge branch 'master' into spring-boot-starter

2385ab0

update build script to fix pom generation, enforced InternalLoggerBea…

4bd0b4b

…n to be created first

improving the way to locate agent and registering web app

bc19586

adding way to get empty telemetry configuration object

b2fbcd9

adding max_instant_rety configuration for boot

be1e235

Merge branch 'master' into spring-boot-starter

ce361b4

refactoring spelling error

94cdc2d

Merge branch 'spring-boot-starter' of https://github.com/Microsoft/Ap…

9aa1fc0

…plicationInsights-Java into spring-boot-starter

Merge branch 'master' into spring-boot-starter

abc91c3

fix a test

b7ef489

fixing broken initialization

943ad11

changing SpringBootContextInitializer to TelemetryInitializer, contex…

79b5f0c

…tTags are not reflected on UX if not in bond schema definition

updating enabling web modules and enabling AI, adding autoconfigurati…

1580e79

…on for JMX counters and JVM counters

migrate tests to junit4

3d194e5

Merge branch 'master' into spring-boot-starter

905304b

dhaval24 added 2 commits April 23, 2018 17:04

Merge branch 'master' into spring-boot-starter

7cf8f72

updating the archive base name for consistency, adding javadocs

5e56ee3

This was referenced Apr 24, 2018

Spring Boot Starter for Java SDK: auto-configure cloud_roleName #643

Closed

Remove Misleading Log Messages in WebRequestTrackingFilter #579

Closed

dhaval24 commented Apr 24, 2018

View reviewed changes

littleaj suggested changes Apr 25, 2018

View reviewed changes

dhaval24 added 2 commits April 25, 2018 18:11

adding null check, some fixes and reducing styling

642cbe7

fix test and intermediate commit

62c50fe

gavlyukovskiy reviewed Apr 26, 2018

View reviewed changes

gavlyukovskiy mentioned this pull request May 2, 2018

add telemetry in application insights microsoft/azure-spring-boot#322

Merged

dhaval24 added 3 commits May 3, 2018 20:48

removing TelemetryType enum for better maintanability, refactoring st…

613e59d

…arter accordingly, making HeartBeatPayloadProviderInterface bean, fixing critical issue with sampling configuration

Revert "improving the way to locate agent and registering web app"

1a24b0a

This reverts commit bc19586.

resolving merge conflict

aa4c93c

dhaval24 mentioned this pull request May 4, 2018

updating agent detection in filter #660

Merged

modularizing way to specify version number of starter, adding starter…

b9936e6

… version number to HB telemetry

reverting a file and fixing dual initialization

58b9028

dhaval24 commented May 14, 2018

View reviewed changes

adding the configuration parity tests

4a843ba

littleaj approved these changes May 16, 2018

View reviewed changes

grlima approved these changes May 16, 2018

View reviewed changes

dhaval24 added 3 commits May 16, 2018 16:11

updating readme with migration steps

abba801

Merge branch 'master' into spring-boot-starter

ba6d722

Smoke Tests for SpringBoot Application using SpringBoot AI Starter (#665

0f67356

) * smoke test for SpringBoot * smoke test app springboot * trying java 7 * trying source and target compatibility * fixing assert * enabling the temporarily disbabled smoke tests * Reverting temporary adjustments

dhaval24 merged commit cbb51bd into master May 16, 2018

dhaval24 mentioned this pull request May 29, 2018

POST /QuickPulseService.svc fails if instrumentation key is set programmatically #573

Closed

dhaval24 deleted the spring-boot-starter branch September 16, 2018 15:52

		@@ -21,15 +21,11 @@

		package com.microsoft.applicationinsights.channel.concrete.inprocess;

		@@ -0,0 +1,19 @@
		package com.microsoft.applicationinsights.internal.channel.samplingV2;

Azure Application Insights SpringBoot Starter #646

Azure Application Insights SpringBoot Starter #646

Conversation

dhaval24 commented Apr 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhaval24 Apr 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhaval24 Apr 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

littleaj commented Apr 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhaval24 commented May 4, 2018

dhaval24 commented May 13, 2018

Choose a reason for hiding this comment

dhaval24 commented May 15, 2018

grlima left a comment

Choose a reason for hiding this comment

dhaval24 commented Apr 12, 2018 •

edited

Loading

dhaval24 Apr 25, 2018 •

edited

Loading

dhaval24 Apr 26, 2018 •

edited

Loading