Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

add telemetry in application insights #322

Merged
merged 4 commits into from
May 4, 2018
Merged

add telemetry in application insights #322

merged 4 commits into from
May 4, 2018

Conversation

yungezz
Copy link
Contributor

@yungezz yungezz commented May 2, 2018

Summary

add telemetry in application insights. and property to enable/disable telemetry configuration. and doc update.

Issue Type

  • New Feature

Starter Names

  • active directory spring boot starter
  • documentdb spring boot starter
  • key vault spring boot starter
  • media services spring boot starter
  • service bus spring boot starter
  • storage spring boot starter

Additional Information

"ReformatCode" in IntelliJ

@gavlyukovskiy
Copy link

We've already done this and more in the application insights repository: microsoft/ApplicationInsights-Java#646

There is auto-configuration for TelemetryClient and all applications insights modules out of the box.
We had intention to do PR here once it is ready, but it's still in testing phase.

@yungezz
Copy link
Contributor Author

yungezz commented May 3, 2018

@gavlyukovskiy HI Arthur, I've aware of the PR to build application insight spring boot starter. But they're 2 different things comparing with this PR. This PR initial is to collect telemetry in our spring boot starters to application insight, it's internal usage, not user-oriented.

  • ai key is not set as property, we dont alllow user to set ai key.
  • telemetryclient is not exposed to user as bean. it's internal used.

Hope this clarifies.

@yungezz yungezz merged commit 99174e5 into master May 4, 2018
@yungezz yungezz deleted the yungez-ai branch May 4, 2018 02:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants