Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Misleading Log Messages in WebRequestTrackingFilter #579

Closed
dhaval24 opened this issue Feb 27, 2018 · 3 comments
Closed

Remove Misleading Log Messages in WebRequestTrackingFilter #579

dhaval24 opened this issue Feb 27, 2018 · 3 comments
Assignees
Labels

Comments

@dhaval24
Copy link
Contributor

The log message in the catch block inside initialize(FilterConfig filterConfig) method in WebRequestTrackingFilter.java class is very misleading. This is emitted even in situations when user doesn't use the agent and filter is successfully registered.

PS: It is general behavior of the filter to test if agent is present and throw. The catch statements should be specific and use different logs for different exceptions.

@dhaval24
Copy link
Contributor Author

#646 will address this.

@littleaj
Copy link
Contributor

littleaj commented Apr 25, 2018

Which log message? I don't see one that is obviously misleading.

@dhaval24
Copy link
Contributor Author

dhaval24 commented Aug 5, 2018

This has been resolved.

@dhaval24 dhaval24 closed this as completed Aug 5, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants