Skip to content

fix: Make parseMetaMaskUrl platform agnostic #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2024
Merged

fix: Make parseMetaMaskUrl platform agnostic #2834

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21e0c90
validation fix
hmalik88 Oct 11, 2024
594d70e
update
hmalik88 Oct 11, 2024
dfa30f1
fix
hmalik88 Oct 11, 2024
32fa2f6
add comment
hmalik88 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/snaps-utils/src/url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,20 @@ export function parseMetaMaskUrl(str: string): {
path: string;
} {
const url = new URL(str);
const { hostname: authority, pathname: path, protocol } = url;
const { protocol } = url;
if (protocol !== 'metamask:') {
throw new Error(
`Unable to parse URL. Expected the protocol to be "metamask:", but received "${protocol}".`,
);
}

// The browser version of URL differs from the Node version so we rely on the href
// property to grab the relevant parts of the url instead of hostname and pathname
const [authority, ...pathElements] = url.href
.replace('metamask://', '')
.split('/');
const path = `/${pathElements.join('/')}`;

switch (authority) {
case 'client':
assert(
Expand Down
Loading