Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make parseMetaMaskUrl platform agnostic #2834

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

hmalik88
Copy link
Contributor

URL in the browser does not populate the hostname property, additional logic is added to handle this.

@hmalik88 hmalik88 requested a review from a team as a code owner October 11, 2024 17:08
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (68761fb) to head (32fa2f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2834   +/-   ##
=======================================
  Coverage   94.45%   94.46%           
=======================================
  Files         484      484           
  Lines       10341    10343    +2     
  Branches     1576     1576           
=======================================
+ Hits         9768     9770    +2     
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding changed the title Fix: parseMetaMaskUrl fix fix: Make parseMetaMaskUrl platform agnostic Oct 14, 2024
@hmalik88 hmalik88 merged commit 4be3dd3 into main Oct 14, 2024
166 checks passed
@hmalik88 hmalik88 deleted the hm/link-validation-fix branch October 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants