Convert createWindow parameters to options bag and add testid option #2765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
createWindow
function to use an options bag for its parameters, improving clarity and extensibility. Additionally, it introduces a newtestId
option, allowing customization of thedata-testid
attribute for the generated iframe.We need this change in the MetaMask/ocap-kernel package (see issue), where the
createWindow
function is used, to set a different testId that doesn't conflict with the snaps iframe. This will ensure clear differentiation when using iframes across different packages.Updated and expanded the test suite to cover the presence and absence of sandbox and testId attributes.