proper spy on createElement

MetaMask · Sep 26, 2024 · 3662874 · 3662874
1 parent 8a8a30a
commit 3662874
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/packages/snaps-utils/src/iframe.test.browser.ts b/packages/snaps-utils/src/iframe.test.browser.ts
@@ -1,3 +1,5 @@
+import { spy } from '@metamask/snaps-utils/test-utils';
+
 import { createWindow } from './iframe';
 
 const IFRAME_URL = `http://localhost:4569`;
@@ -60,16 +62,20 @@ describe('createWindow', () => {
   });
 
   it('rejects the promise if contentWindow is not present', async () => {
-    jest.spyOn(document, 'createElement').mockImplementationOnce(() => {
-      const iframe = document.createElement('iframe');
-      Object.defineProperty(iframe, 'contentWindow', { value: null });
-      return iframe;
-    });
+    const createElementSpy = spy(document, 'createElement').mockImplementation(
+      () => {
+        const iframe = document.createElement('iframe');
+        Object.defineProperty(iframe, 'contentWindow', { value: null });
+        return iframe;
+      },
+    );
 
     await expect(
       createWindow({ uri: IFRAME_URL, id: MOCK_JOB_ID }),
     ).rejects.toThrow(
       `iframe.contentWindow not present on load for job "${MOCK_JOB_ID}".`,
     );
+
+    createElementSpy.reset();
   });
 });