Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snaps-registry): Define missing getState action, stateChange event #2655

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Aug 21, 2024

Explanation

Fixes the SnapsRegistryMessenger type and the JsonSnapsRegistry class. Currently they do not fulfill their intended specifications correctly.

This also resolves downstream errors in mobile caused by composable-controller expecting all of its child controllers to have a stateChange event.

References

Changelog

@metamask/snaps-controllers

Added

  • Define and export new types: SnapsRegistryGetStateAction, SnapsRegistryStateChangeEvent (#2655)

Changed

  • SnapsRegistryActions is widened to include the SnapsRegistry:getState action (#2655)
  • SnapsRegistryEvents is widened to include the SnapsRegistry:stateChange event (#2655)

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.27%. Comparing base (4c532f7) to head (1a2a24c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2655   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files         478      478           
  Lines        9999     9999           
  Branches     1499     1499           
=======================================
  Hits         9427     9427           
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MajorLift MajorLift merged commit d6c869e into main Aug 21, 2024
156 checks passed
@MajorLift MajorLift deleted the jongsun/fix-snaps-registry-missing-actions,events branch August 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix controllers with missing or incorrect messenger-related types
2 participants