Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controllers with missing or incorrect messenger-related types #4579

Closed
7 of 8 tasks
desi opened this issue Aug 1, 2024 · 0 comments · Fixed by #4633, MetaMask/snaps#2655 or #4641
Closed
7 of 8 tasks

Fix controllers with missing or incorrect messenger-related types #4579

desi opened this issue Aug 1, 2024 · 0 comments · Fixed by #4633, MetaMask/snaps#2655 or #4641
Assignees
Labels
bug Something isn't working team-wallet-framework

Comments

@desi
Copy link
Contributor

desi commented Aug 1, 2024

Motivation

Some of our controllers currently do not fulfill their intended specifications correctly, which is affecting downstream clients where the controllers are being used.

Explanation

Enforce the following guidelines and their subentries from the writing-controllers doc:

Acceptance Criteria

Fix missing or incorrect implementations of the above guidelines, and publish releases for these fixes.

Applying the yarn patches in this PR to the source packages will be a good starting point: MetaMask/metamask-mobile#10374 (comment)

Examples fixes

Affected Controllers

Core

External

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment