You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of our controllers currently do not fulfill their intended specifications correctly, which is affecting downstream clients where the controllers are being used.
MajorLift
changed the title
Placeholder - Fix missing or incorrect messenger types for controllers
Fix controllers with missing or incorrect messenger-related types
Aug 1, 2024
Motivation
Some of our controllers currently do not fulfill their intended specifications correctly, which is affecting downstream clients where the controllers are being used.
ComposableController
fix with no type error suppression metamask-mobile#10374Explanation
Enforce the following guidelines and their subentries from the
writing-controllers
doc:*:getState
action using theControllerGetStateAction
utility type*:stateChange
event using theControllerStateChangeEvent
utility typeAcceptance Criteria
Fix missing or incorrect implementations of the above guidelines, and publish releases for these fixes.
Applying the yarn patches in this PR to the source packages will be a good starting point: MetaMask/metamask-mobile#10374 (comment)
Examples fixes
PPOMController{,Messenger}
API, bump@metamask/base-controller
to^6.0.2
ppom-validator#193Affected Controllers
Core
LoggingController
PhishingController
NotificationServicesController
AuthenticationController
UserStorageController
External
PPOMController
: Fix incompletePPOMController{,Messenger}
API, bump@metamask/base-controller
to^6.0.2
ppom-validator#193SnapsRegistry
: fix(snaps-registry): Define missinggetState
action,stateChange
event snaps#2655The text was updated successfully, but these errors were encountered: