Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass localized snap name to SubjectMetadataController #2157

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Feb 4, 2024

This upstreams a change that was being made in MetaMask/metamask-extension#21909

@hmalik88 hmalik88 marked this pull request as ready for review February 4, 2024 21:26
@hmalik88 hmalik88 requested a review from a team as a code owner February 4, 2024 21:26
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3be3b19) 96.80% compared to head (944f9d4) 96.59%.
Report is 6 commits behind head on main.

Files Patch % Lines
...s/snaps-simulator/src/features/simulation/sagas.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
- Coverage   96.80%   96.59%   -0.22%     
==========================================
  Files         327      325       -2     
  Lines        7331     7332       +1     
  Branches     1130     1133       +3     
==========================================
- Hits         7097     7082      -15     
- Misses        234      250      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding changed the title Add localized snap name Pass localized snap name to SubjectMetadataController Feb 5, 2024
@hmalik88 hmalik88 merged commit 9a81b2b into main Feb 5, 2024
145 checks passed
@hmalik88 hmalik88 deleted the hm/localize-snaps-name branch February 5, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants