-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for localised Snap manifests #21909
Conversation
@metamaskbot update-policies |
Policies updated |
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [07b8470]
Page Load Metrics (876 ± 423 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #21909 +/- ##
===========================================
+ Coverage 68.29% 68.43% +0.14%
===========================================
Files 1142 1140 -2
Lines 43920 43750 -170
Branches 11777 11718 -59
===========================================
- Hits 29995 29940 -55
+ Misses 13925 13810 -115 ☔ View full report in Codecov by Sentry. |
ui/components/app/permissions-connect-permission-list/permissions-connect-permission-list.js
Outdated
Show resolved
Hide resolved
ui/components/app/snaps/snap-authorship-header/snap-authorship-header.js
Show resolved
Hide resolved
ui/components/app/permissions-connect-permission-list/permissions-connect-permission-list.js
Show resolved
Hide resolved
...e-container/permission-page-container-content/permission-page-container-content.component.js
Outdated
Show resolved
Hide resolved
Builds ready [3d69eb5]
Page Load Metrics (1430 ± 436 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
This adds support for localised Snap manifests. Instead of getting the Snap name from the subject metadata controller, I've added a new selector which returns the localised manifest.
Related to MetaMask/snaps#1508.
Manual testing steps
npm:@metamask/localization-example-snap
from test-snaps.Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist