Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source code and state from runtime #2009

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

FrederikBolding
Copy link
Member

In #1634 we removed the source code and snap state from the runtime type. But the data was still being saved wastefully in memory. This PR fixes this.

@FrederikBolding FrederikBolding requested a review from a team as a code owner December 4, 2023 13:20
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0bbe326) 96.08% compared to head (9705932) 96.08%.
Report is 1 commits behind head on main.

Files Patch % Lines
packages/snaps-utils/src/base64.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   96.08%   96.08%   -0.01%     
==========================================
  Files         267      269       +2     
  Lines        6240     6259      +19     
  Branches     1009     1009              
==========================================
+ Hits         5996     6014      +18     
- Misses        244      245       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 59da0ea into main Dec 4, 2023
137 of 138 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-unused-data-from-runtime branch December 4, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants