Move source code and snap state back to controller state #1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
- Coverage 95.78% 95.77% -0.02%
==========================================
Files 235 235
Lines 5342 5324 -18
Branches 819 817 -2
==========================================
- Hits 5117 5099 -18
Misses 225 225
|
Mrtenz
approved these changes
Jul 22, 2023
FrederikBolding
added a commit
that referenced
this pull request
Aug 7, 2023
* Move source code and snap state back to controller state * Update coverage
FrederikBolding
added a commit
that referenced
this pull request
Aug 8, 2023
* Move source code and snap state back to controller state * Update coverage
Gudahtt
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Move source code and snap state back to controller state * Update coverage
FrederikBolding
added a commit
that referenced
this pull request
Dec 4, 2023
In #1634 we removed the source code and snap state from the runtime type. But the data was still being saved wastefully in memory. This PR fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the source code and snap state from
SnapRuntimeDatato theSnapControllerstate. This fixes a bug with persistence of snap state and source code changes. This change by itself will worsen performance of the extension, so it should be coupled with a change to filter source code and snap state from the state piped to the extension UI.This PR also allows us to move
snapsRuntimeDatato hash private.Fixes #1633