feat: [WIP] Test #9274 + #9925 #9930

legobeat · 2024-06-11T04:13:53Z

Description

This branch exists to sample combination of:

In order to consistently upgrade json-rpc-middleware/@metamask/json-rpc-middleware and related deps.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…rs@^7.0.0

test: type adjustments

github-actions · 2024-06-11T04:14:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-06-11T04:15:10Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`+1`	36.4 kB	lgbot

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security · 2024-06-11T04:15:49Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
New author	npm/[email protected]	New Author: ljharb Previous Author:	`package.json`	🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/[email protected]

github-actions · 2024-06-11T04:39:30Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e160aa5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/90642c6c-9c17-4a58-a990-9fba0b18d005

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-11T14:34:07Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 98fba92
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73196709-a972-46e9-b7ff-8fca48d5639e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-11T18:50:49Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 242934d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/64c2df1d-c2b7-4666-8bfa-d6fb1f1b6801

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-11T18:56:46Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6cfbed3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e092a82-07f9-455a-a90f-87ada120f9f8

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-06-20T17:13:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-06-20T17:49:27Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dfae3be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97fe7cf0-5b2b-4e7e-8583-3c075337a198

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

legobeat · 2024-06-25T01:47:32Z

Closed in favor of #10098

MarioAslau and others added 10 commits June 10, 2024 21:28

feat: use metamask ethJsonRpcMiddleware

205db8f

fix(deps): [email protected] -> @metamask/eth-json-rpc-filte…

d927d34

…rs@^7.0.0

deps: json-rpc-engine@^6.1.0 -> @metamask/json-rpc-engine@^7.1.0

4d2c65f

Update JsonRpcRequest typings

63d560a

test: type adjustments

chainId is now hex string, not number

fbd8509

chore(test): eth_sendTransaction test type workarounds

f1e0653

fixup: console.error in test

e4e7599

fix(test): test for error cause message in RPCMethodMIddleware

4a914af

chore: update test

e1d2a04

chore: wip: add @ts-expect-error directive

0c1a8a1

legobeat added dependencies Pull requests that update a dependency file team-security labels Jun 11, 2024

legobeat changed the title ~~[WIP] Test #9274 + #9925~~ feat: [WIP] Test #9274 + #9925 Jun 11, 2024

Merge branch 'feat/eth-json-rpc' into json-rpc-middleware-12

69a39cc

legobeat force-pushed the json-rpc-middleware-12 branch from c3e99d9 to 69a39cc Compare June 11, 2024 04:31

chore: update .iyarc

e160aa5

legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 11, 2024

legobeat mentioned this pull request Jun 11, 2024

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

Draft

12 tasks

Merge branch 'main' into json-rpc-middleware-12

98fba92

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024

MarioAslau mentioned this pull request Jun 11, 2024

Add @metamask/eth-json-rpc-middleware #9925

Closed

7 tasks

feat: downgrade from 12 to 11

242934d

MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024

Merge branch 'main' into json-rpc-middleware-12

6cfbed3

MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024

Merge branch 'main' into json-rpc-middleware-12

dfae3be

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 20, 2024

tommasini mentioned this pull request Jun 24, 2024

chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098

Draft

7 tasks

legobeat closed this Jun 25, 2024

github-actions bot locked and limited conversation to collaborators Jun 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [WIP] Test #9274 + #9925 #9930

feat: [WIP] Test #9274 + #9925 #9930

legobeat commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024

socket-security bot commented Jun 11, 2024 •

edited

Loading

socket-security bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

sonarcloud bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024 •

edited by metamaskbot

Loading

legobeat commented Jun 25, 2024

feat: [WIP] Test #9274 + #9925 #9930

feat: [WIP] Test #9274 + #9925 #9930

Conversation

legobeat commented Jun 11, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 11, 2024

socket-security bot commented Jun 11, 2024 • edited Loading

socket-security bot commented Jun 11, 2024 • edited Loading

Next steps

github-actions bot commented Jun 11, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jun 11, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jun 11, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jun 11, 2024 • edited by metamaskbot Loading

Bitrise

sonarcloud bot commented Jun 20, 2024

Quality Gate passed

github-actions bot commented Jun 20, 2024 • edited by metamaskbot Loading

Bitrise

legobeat commented Jun 25, 2024

legobeat commented Jun 11, 2024 •

edited

Loading

socket-security bot commented Jun 11, 2024 •

edited

Loading

socket-security bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 20, 2024 •

edited by metamaskbot

Loading