fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

legobeat · 2024-04-17T04:26:50Z

Description

The runtime dependencies eth-json-rpc-filters and json-rpc-engine are both deprecated. This replaces them with their successors @metamask/eth-json-rpc-filters and @metamask/json-rpc-engine, respectively.

Related issues

Manual testing steps

n/a

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2024-04-17T04:28:32Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

legobeat · 2024-04-17T04:32:01Z

@SocketSecurity ignore npm/@metamask/[email protected]

socket-security · 2024-04-17T07:29:48Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	24.6 kB	lgbot

🚮 Removed packages: npm/[email protected]

View full report↗︎

github-actions · 2024-06-11T03:20:36Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4a914af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bcc52743-ae03-4059-a97b-abd804453cc0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

legobeat · 2024-06-11T03:41:12Z

@legobeat Still working on this? It looks like based on the CI failures that we might need to bump transaction-controller?

Recently, no. And yes, looks like that is related. Would you know which version of @metamask/transaction-controller would unlock this?

Looking at it now, the mismatching types due to mismatching versions look like they should be resolved by upgrading @metamask/transaction-controller from ^13 to ^15, which implies a bump of @metamask/network-controller to ^15 and its @metamask/json-rpc-middleware from ^11 to ^12.

Related: Add @metamask/eth-json-rpc-middleware #9925

legobeat · 2024-06-11T03:45:45Z

The failing Check for js or jsx file being added rule seems to FP on changed files and interpreting them as added.

…rs@^7.0.0

test: type adjustments

github-actions · 2024-06-11T05:04:55Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-06-11T05:14:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-06-11T05:35:52Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-11T05:36:19Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-11T05:37:37Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-11T05:37:44Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

This comment was marked as off-topic.

Sign in to view

legobeat changed the title ~~Deps eth json rpc filters~~ fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine Apr 17, 2024

legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 17, 2024

legobeat force-pushed the deps-eth-json-rpc-filters branch from b3da306 to 27ade1b Compare April 17, 2024 04:30

legobeat mentioned this pull request Apr 17, 2024

fix(deps): @metamask/transaction-controller@^8.0.1->^12.0.0 #9275

Closed

7 tasks

legobeat force-pushed the deps-eth-json-rpc-filters branch 4 times, most recently from 53c8a35 to 69be175 Compare April 18, 2024 21:09

legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 18, 2024

This comment was marked as outdated.

Sign in to view

legobeat force-pushed the deps-eth-json-rpc-filters branch 3 times, most recently from a443778 to 9b7463f Compare April 18, 2024 22:03

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 18, 2024

This comment was marked as outdated.

Sign in to view

legobeat requested review from mcmire, FrederikBolding and Mrtenz April 18, 2024 22:22

legobeat force-pushed the deps-eth-json-rpc-filters branch from 6cec69d to 45cfe8d Compare April 19, 2024 03:01

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024

This comment was marked as outdated.

Sign in to view

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024

legobeat added the DO-NOT-MERGE Pull requests that should not be merged label Jun 11, 2024

This comment was marked as resolved.

Sign in to view

legobeat added 8 commits June 11, 2024 12:49

fix(deps): [email protected] -> @metamask/eth-json-rpc-filte…

b63bd1d

…rs@^7.0.0

deps: json-rpc-engine@^6.1.0 -> @metamask/json-rpc-engine@^7.1.0

f13d101

Update JsonRpcRequest typings

db88895

test: type adjustments

chainId is now hex string, not number

9fd2303

chore(test): eth_sendTransaction test type workarounds

dcfcf88

fixup: console.error in test

4c07891

fix(test): test for error cause message in RPCMethodMIddleware

44a560a

chore: update test

87ff0e2

legobeat force-pushed the deps-eth-json-rpc-filters branch from 0c1a8a1 to edecb3c Compare June 11, 2024 03:49

This was referenced Jun 11, 2024

feat: [WIP] Test #9274 + #9925 #9930

Closed

Upgrade @metamask/transaction-controller from ^13 to min ^15 #9931

Closed

chore: restore @ts-expect-error directive

8920824

legobeat force-pushed the deps-eth-json-rpc-filters branch from edecb3c to 8920824 Compare June 11, 2024 05:02

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024

Mrtenz removed their request for review July 4, 2024 09:12

legobeat mentioned this pull request Sep 20, 2024

chore: bump network controller 21.0.0 #11292

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

legobeat commented Apr 17, 2024 •

edited

Loading

This comment was marked as off-topic.

socket-security bot commented Apr 17, 2024 •

edited

Loading

legobeat commented Apr 17, 2024

socket-security bot commented Apr 17, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

legobeat commented Jun 11, 2024 •

edited

Loading

legobeat commented Jun 11, 2024

This comment was marked as resolved.

github-actions bot commented Jun 11, 2024

sonarcloud bot commented Jun 11, 2024

metamaskbot commented Jun 11, 2024

metamaskbot commented Jun 11, 2024

metamaskbot commented Jun 11, 2024

metamaskbot commented Jun 11, 2024

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

Are you sure you want to change the base?

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

Conversation

legobeat commented Apr 17, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

This comment was marked as off-topic.

socket-security bot commented Apr 17, 2024 • edited Loading

legobeat commented Apr 17, 2024

socket-security bot commented Apr 17, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Jun 11, 2024 • edited by metamaskbot Loading

Bitrise

legobeat commented Jun 11, 2024 • edited Loading

legobeat commented Jun 11, 2024

This comment was marked as resolved.

github-actions bot commented Jun 11, 2024

Bitrise

sonarcloud bot commented Jun 11, 2024

Quality Gate passed

metamaskbot commented Jun 11, 2024

Bitrise

metamaskbot commented Jun 11, 2024

Bitrise

metamaskbot commented Jun 11, 2024

Bitrise

metamaskbot commented Jun 11, 2024

Bitrise

legobeat commented Apr 17, 2024 •

edited

Loading

socket-security bot commented Apr 17, 2024 •

edited

Loading

socket-security bot commented Apr 17, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited by metamaskbot

Loading

legobeat commented Jun 11, 2024 •

edited

Loading