-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Fix mobile sync & Security options #989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 💯 nice pr, code lgtm
Issue 1: When saying no to touch ID and then killing/relaunching app, I’m prompted with touch ID Steps: Issue 2: I enable touch ID via settings, then log out, I still see remember me and then once logging back in, touch ID is disabled Steps: Same thing happens if I enable touch ID in settings, kill app, relaunch, then log out Issue 3: When on a device that doesn't support biometrics, but does support pin/passcode I get an error Note: this happens with a device that doesn't have pin enabled as well Seen here = http://recordit.co/CSfy5TWEQj Issue 4: When I try the import seed phrase flow, and toggle OFF the fingerprint option then continue onwards, before being shown the opt in view, I’m prompted to enter my pin passcode where it says “Please authenticate in order to use MetaMask” Steps: |
Fixes look good, QA Passed 👍 |
* fix mobile sync * clean up * add device passcode option * code review comments * disable passcode while cancelling biometrics on sync * fix issue 2 * fix import from seed scenario * minor fixes * update snapshots
This PR addresses three separate issues related to sync & security / biometrics
When one request failed, the retry logic kept two listeners active, which causes all the messages to arrive twice. That breaks the json structure while rebuilding the state, throwing an exception on JSON.parse
This PR updates the way we handle the listener removal based on the pubnub docs and also bumps
pubnub
dep to its latest version, which was different to the one that we were using in the extension and I'm updating on a separate PR.In order to fix the issue with older versions of the extension where the same messages can still be sent twice I've added a check to make sure if it's repeated to be ignored.
Fixes #896
Additionally fixes a bug with the flag
biometryChoiceDisabled
which was being reset every time the login screen was shownFixes #985 and also #927
If you disable biometrics it will fallback to device PIN, if you disable device PIN it will default to password.