Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint unlock with fingerprint unlocking disabled! #985

Closed
MicahZoltu opened this issue Aug 4, 2019 · 7 comments · Fixed by #989
Closed

Fingerprint unlock with fingerprint unlocking disabled! #985

MicahZoltu opened this issue Aug 4, 2019 · 7 comments · Fixed by #989

Comments

@MicahZoltu
Copy link

  1. Install MetaMask app from Play Store.
  2. Sync with desktop browser extension.
  3. Go to security settings in app and ensure Fingerprint unlock is disabled.
  4. Close MetaMask app.
  5. Open MetaMask app.
    --> Notice that you are prompted for a fingerprint to unlock the app!

This is a pretty big security issue for me as biometrics alone are NOT secure. While I have them setup for unlocking my phone, all of my financial apps are secured behind something I know, not something I have since getting into my phone in the first place requires something I have (biometrics + device).

@brunobar79
Copy link
Contributor

brunobar79 commented Aug 6, 2019

Hey there. thanks for reporting. I can confirm that this is definitely a bug on our end and it's not intended to work that way.

The first problem is related to #927 where we are enabling it by default during sync without actually asking the user if they want to do it.

The second problem is that the option "Sign in with Fingerprint" it's not reflecting the ON state after the sync.

Both problems will get fixed on our next release.

@MicahZoltu
Copy link
Author

When is this expected to land in a release?

@brunobar79
Copy link
Contributor

Monday / tuesday the latest.

@jumpnkick
Copy link

Two months now. Still having this problem... Funny thing it used to work fine on previous releases.
No solution yet, or is it on my side the prob?
Thanx!

@estebanmino
Copy link
Contributor

Hi @jumpnkick thanks for reporting, I've been trying to reproduce in a Samsung S9 but I can't. Which device are you using? Also, metamask version? Thanks!

@jumpnkick
Copy link

OnePlus 3t.
MetaMask 0.2.8
Thank you!

@jumpnkick
Copy link

Just tried it again. It started working now.
Funny thing I didn't update or reinstall it.
Simply started working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants