fix(deps): replace react-native-aes-crypto-forked with react-native-aes-crypto
#9540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
added
dependencies
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected]) |
legobeat
force-pushed
the
deps-mm-react-native-aes-crypto
branch
from
20011ca
to
df9d0da
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
legobeat
added
Run Smoke E2E
This comment was marked as outdated.
This comment was marked as outdated.
legobeat
force-pushed
the
deps-mm-react-native-aes-crypto
branch
2 times, most recently
from
3bbf657
to
55ec4c6
Compare
legobeat
added
Run Smoke E2E
This comment was marked as outdated.
This comment was marked as outdated.
legobeat
force-pushed
the
deps-mm-react-native-aes-crypto
branch
3 times, most recently
from
0dfba57
to
6ee5042
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
legobeat
force-pushed
the
deps-mm-react-native-aes-crypto
branch
3 times, most recently
from
0acc26f
to
b8331c7
Compare
legobeat
force-pushed
the
deps-mm-react-native-aes-crypto
branch
from
b8331c7
to
c8a6259
Compare
owencraston
added a commit
that referenced
this pull request
Jul 23, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The changes on this PR includes, - Bump of the `aes-react-native` module from 1.3.9 to 3.0.2 This PR depends on #9898 ## **Related issues** Fixes: MetaMask/mobile-planning#1551 - #9540 ## **Manual testing steps** ### Upgrade app - Wallet creation 1. Build the latest release of the app and create a wallet 2. Add an account by importing the private key 3. Lock the wallet 4. Change branches to this one (`feat/bump-rn-aes`) 5. Unlock the wallet 6. Lock and Unlock again 7. Check SRP and private keys are accessible 8. Use the MM Test Dapp to sign messages 9. Use the send transaction feature with a testnet ### Upgrade app - Import SRP 1. Build the latest release of the app and import a SRP 2. Follow the steps from the first test case from step 2 ### Create a wallet 1. Create a new wallet 2. Follow the steps from the first test case from step 2 ### Import a SRP 1. Import a SRP 2. Follow the steps from the first test case from step 2 ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/17601467/982a879b-9d22-4afd-9b47-65db1b0120d7 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: legobeat <[email protected]> Co-authored-by: Daniel Rocha <[email protected]> Co-authored-by: Owen Craston <[email protected]>
- package.json - yarn.lock (run deduplicate) - react-native.config.js (removed in RN 0.74) - depcheck
This reverts commit 22bf1b0.
This reverts commit b700a29.
- Fix CompileC RCTAesForked.m failure
- Fix fatal error: 'React/RCTBridgeModule.h' file not found in
- #import <React/RCTBridgeModule.h>
- Remove libRCTAesForked.a via Xcode
7 tasks
legobeat
force-pushed
the
deps-mm-react-native-aes-crypto
branch
from
332ea5b
to
b9307d8
Compare
legobeat
added
Run Smoke E2E
|
legobeat
commented
Jul 23, 2024
| - minSdkVersion 19 | ||
| - targetSdkVersion 22 | ||
| + minSdkVersion 21 | ||
| + targetSdkVersion 33 |
There was a problem hiding this comment.
devin-ai-integration bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The changes on this PR includes, - Bump of the `aes-react-native` module from 1.3.9 to 3.0.2 This PR depends on #9898 ## **Related issues** Fixes: https://github.com/MetaMask/mobile-planning/issues/1551 - #9540 ## **Manual testing steps** ### Upgrade app - Wallet creation 1. Build the latest release of the app and create a wallet 2. Add an account by importing the private key 3. Lock the wallet 4. Change branches to this one (`feat/bump-rn-aes`) 5. Unlock the wallet 6. Lock and Unlock again 7. Check SRP and private keys are accessible 8. Use the MM Test Dapp to sign messages 9. Use the send transaction feature with a testnet ### Upgrade app - Import SRP 1. Build the latest release of the app and import a SRP 2. Follow the steps from the first test case from step 2 ### Create a wallet 1. Create a new wallet 2. Follow the steps from the first test case from step 2 ### Import a SRP 1. Import a SRP 2. Follow the steps from the first test case from step 2 ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/17601467/982a879b-9d22-4afd-9b47-65db1b0120d7 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: legobeat <[email protected]> Co-authored-by: Daniel Rocha <[email protected]> Co-authored-by: Owen Craston <[email protected]>
legobeat
added
Run Smoke E2E
This comment was marked as outdated.
This comment was marked as outdated.
legobeat
added
Run Smoke E2E
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of pulling in
react-native-aes-crypto-forkedfrom a git-commit and then patching it (!(?)), this migrates to a published version of the package under the name@metamask/react-native-aes-cryptowith the same effect.The separate dependency
react-native-aes-cryptois left unaddressed.Related issues
Blocked by
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist