Update react native aes crypto forked #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
the
needs-qa
rickycodes
approved these changes
Aug 25, 2020
ibrahimtaveras00
added
QA Passed
estebanmino
deleted the
improvement/update-react-native-aes-crypto-forked
branch
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Update react native aes crypto forked * update file license Co-authored-by: Esteban Miño <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update react native aes crypto forked
@ibrahimtaveras00 testing should be more or less the same as what was done for #1755. So testing updating from an older app version that still uses the old crypto lib, for example, 0.2.19 to this version. Logging with or without password should work and also accounts, either imported or not, should also be there.